From mboxrd@z Thu Jan  1 00:00:00 1970
From: Asias He <asias.hejun@gmail.com>
Subject: Re: [PATCH 3/3] kvm tools: add virtio console support v2
Date: Fri, 08 Apr 2011 22:18:30 +0800
Message-ID: <4D9F1936.8080902@gmail.com>
References: <1302228309-6583-1-git-send-email-asias.hejun@gmail.com> <1302228309-6583-3-git-send-email-asias.hejun@gmail.com> <4D9D509D.3010903@cs.helsinki.fi>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
	Prasad Joshi <prasadjoshi124@gmail.com>, kvm@vger.kernel.org
To: Pekka Enberg <penberg@cs.helsinki.fi>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-gy0-f174.google.com ([209.85.160.174]:41462 "EHLO
	mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751807Ab1DGOT3 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 7 Apr 2011 10:19:29 -0400
Received: by gyd10 with SMTP id 10so1027239gyd.19
        for <kvm@vger.kernel.org>; Thu, 07 Apr 2011 07:19:29 -0700 (PDT)
In-Reply-To: <4D9D509D.3010903@cs.helsinki.fi>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 04/07/2011 01:50 PM, Pekka Enberg wrote:
> Hi Asias,
> 
> On 4/8/11 5:05 AM, Asias He wrote:
>> - Consolidate all console related code to term.c
>> - Use timer based approach instead of thread to deal with user input
>> - Introduce --enable-virtio-console option, this option disables
>>    serial console output
>>
>> NOTE:
>> Please add something like this:
>> T2:23:respawn:/sbin/getty -L hvc0 9600 vt100
>> to your /etc/inittab file to get a virtio console login.
>>
>> Signed-off-by: Asias He<asias.hejun@gmail.com>
>> ---
>>   tools/kvm/8250-serial.c                |   40 +-----
>>   tools/kvm/Makefile                     |    2 +
>>   tools/kvm/console-virtio.c             |  218
>> ++++++++++++++++++++++++++++++++
>>   tools/kvm/include/kvm/8250-serial.h    |    2 +-
>>   tools/kvm/include/kvm/console-virtio.h |    9 ++
>>   tools/kvm/include/kvm/term.h           |   17 +++
>>   tools/kvm/main.c                       |   48 ++-----
>>   tools/kvm/term.c                       |   89 +++++++++++++
> 
> Is it too much trouble to ask you to split this patch into two: (1) the
> term.c refactoring and (2) virtio console implementation? That would
> make the series much easier to review.
> 

Hi, Pekka

I have split the patch and sent it out.

-- 
Best Regards,
Asias He