From: Avi Kivity <avi@redhat.com>
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: KVM mailing list <kvm@vger.kernel.org>
Subject: Re: buggy emulate_int_real
Date: Sun, 10 Apr 2011 11:30:25 +0300 [thread overview]
Message-ID: <4DA16AA1.7010108@redhat.com> (raw)
In-Reply-To: <20110408210900.GA26787@hallyn.com>
On 04/09/2011 12:09 AM, Serge E. Hallyn wrote:
> Hi,
>
> at https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/747090, it was
> found that emulate_int_real() sometimes pushes the wrong eip when doing a
> int. Whereas with non-kvm qemu we push the next instruction after the
> int, with kvm we push the addr of the instruction itself.
>
The code says:
c->src.val = c->eip;
emulate_push(ctxt, ops);
rc = writeback(ctxt, ops);
if (rc != X86EMUL_CONTINUE)
return rc;
which appears to be the address of the next instruction from my reading
of the code (see how insn_fetch() increments c->eip).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-04-10 8:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 21:09 buggy emulate_int_real Serge E. Hallyn
2011-04-10 8:30 ` Avi Kivity [this message]
2011-04-12 7:53 ` Serge E. Hallyn
2011-04-12 8:02 ` Avi Kivity
2011-04-12 13:57 ` Serge E. Hallyn
2011-04-12 14:14 ` Avi Kivity
2011-04-12 14:12 ` Serge E. Hallyn
2011-04-12 14:16 ` Avi Kivity
2011-04-12 15:42 ` Jan Kiszka
2011-04-12 18:31 ` Serge E. Hallyn
2011-04-12 20:51 ` Jan Kiszka
2011-04-12 21:25 ` Serge E. Hallyn
2011-04-12 22:39 ` Serge E. Hallyn
2011-04-12 23:31 ` Jan Kiszka
2011-04-13 13:24 ` Serge E. Hallyn
2011-04-13 13:29 ` Avi Kivity
2011-04-13 13:52 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA16AA1.7010108@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox