From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command Date: Sun, 10 Apr 2011 11:52:27 +0300 Message-ID: <4DA16FCB.7040509@redhat.com> References: <4D9CAAF9.7000509@codemonkey.ws> <20110406150818.56707b9b@doriath> <4D9CAE4B.7080305@siemens.com> <20110406160020.373cb5a2@doriath> <4D9CC044.2000705@codemonkey.ws> <4D9E0352.2050204@codemonkey.ws> <20110407185108.GE7100@redhat.com> <20110407191759.GG7100@redhat.com> <4D9E2F6F.3040008@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , Blue Swirl , Peter Maydell , Lai Jiangshan , Jiangshan , kvm@vger.kernel.org, Jan Kiszka , qemu-devel@nongnu.org, Markus Armbruster , Luiz Capitulino To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:32782 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753125Ab1DJIwq (ORCPT ); Sun, 10 Apr 2011 04:52:46 -0400 In-Reply-To: <4D9E2F6F.3040008@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 04/08/2011 12:41 AM, Anthony Liguori wrote: > > And it's a good thing to have, but exposing this as the only API to do > something as simple as generating a guest crash dump is not the > friendliest thing in the world to do to users. nmi is a fine name for something that corresponds to a real-life nmi button (often labeled "NMI"). generate-crash-dump is a wrong name for something that doesn't generate a crash dump (the guest may not be configured for it, or it may fail to work). I'd expect that to be host-side functionality. -- error compiling committee.c: too many arguments to function