From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org, mtosatti@redhat.com
Subject: Re: [PATCH 4/5] KVM: Fix compound mmio.
Date: Tue, 12 Apr 2011 15:19:00 +0300 [thread overview]
Message-ID: <4DA44334.2090905@redhat.com> (raw)
In-Reply-To: <1302600985-10704-4-git-send-email-gleb@redhat.com>
On 04/12/2011 12:36 PM, Gleb Natapov wrote:
> mmio_index should be taken into account when copying data from
> userspace.
>
> Signed-off-by: Gleb Natapov<gleb@redhat.com>
> ---
> arch/x86/kvm/x86.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index b568779..609c7ab 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -5518,7 +5518,8 @@ static int complete_mmio(struct kvm_vcpu *vcpu)
> if (vcpu->mmio_needed) {
> vcpu->mmio_needed = 0;
> if (!vcpu->mmio_is_write)
> - memcpy(vcpu->mmio_data, run->mmio.data, 8);
> + memcpy(vcpu->mmio_data + vcpu->mmio_index,
> + run->mmio.data, 8);
> vcpu->mmio_index += 8;
> if (vcpu->mmio_index< vcpu->mmio_size) {
> run->exit_reason = KVM_EXIT_MMIO;
Interesting, the code passed the emulator.flat sse test. Does it now?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-04-12 12:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 9:36 [PATCH 1/5] KVM: mmio_fault_cr2 is not used Gleb Natapov
2011-04-12 9:36 ` [PATCH 2/5] KVM: emulator: sysexit should #GP in non protected mode Gleb Natapov
2011-04-12 12:17 ` Avi Kivity
2011-04-12 12:23 ` Gleb Natapov
2011-04-12 12:30 ` Avi Kivity
2011-04-12 9:36 ` [PATCH 3/5] KVM: emulator: Propagate fault in far jump emulation Gleb Natapov
2011-04-12 9:36 ` [PATCH 4/5] KVM: Fix compound mmio Gleb Natapov
2011-04-12 12:19 ` Avi Kivity [this message]
2011-04-12 12:22 ` Gleb Natapov
2011-04-12 12:27 ` Avi Kivity
2011-04-12 12:34 ` Gleb Natapov
2011-04-12 12:41 ` Avi Kivity
2011-04-12 9:36 ` [PATCH 5/5] KVM: call cache_all_regs() only once during instruction emulation Gleb Natapov
2011-04-26 8:25 ` [PATCH 1/5] KVM: mmio_fault_cr2 is not used Gleb Natapov
2011-04-26 10:15 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA44334.2090905@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox