From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH 2/2] kvm tools: Make host side IP configurable
Date: Wed, 13 Apr 2011 15:35:24 +0300
Message-ID: <4DA5988C.50908@cs.helsinki.fi>
References: <1302696804-29684-1-git-send-email-levinsasha928@gmail.com> <1302696804-29684-2-git-send-email-levinsasha928@gmail.com> <4DA59704.8@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Sasha Levin <levinsasha928@gmail.com>, gorcunov@gmail.com,
	kvm@vger.kernel.org, mingo@elte.hu
To: Asias He <asias.hejun@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from courier.cs.helsinki.fi ([128.214.9.1]:37973 "EHLO
	mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750707Ab1DMMf0 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 13 Apr 2011 08:35:26 -0400
In-Reply-To: <4DA59704.8@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 4/13/11 3:28 PM, Asias He wrote:
> On 04/13/2011 08:13 PM, Sasha Levin wrote:
>> Add --host-ip-addr parameter to allow changing the host-side IP address.
>
> I'd personally prefer something like this:
>
> --network=model=virtio,hostip=x.x.x.x/mask,guestmac=yy:yy:yy:yy
>
> Once we can set up ip address for guest, we can use:
>
> --network=model=virtio,hostip=x.x.x.x/mask,guestmac=yy:yy:yy:yy,guestip=z.z.z.z/mask,guestgw=v.v.v.v

What's the benefit over

   --network=virtio --hostip=x.x.x.x/mask --guestmac= [...]

form? Isn't Sasha's form a much better fit with the git-like front end 
(for parsing and help text)?

                 Pekka