From mboxrd@z Thu Jan 1 00:00:00 1970 From: Asias He Subject: Re: [PATCH 2/2] kvm tools: Make host side IP configurable Date: Wed, 13 Apr 2011 22:13:10 +0800 Message-ID: <4DA5AF76.3070301@gmail.com> References: <1302696804-29684-1-git-send-email-levinsasha928@gmail.com> <1302696804-29684-2-git-send-email-levinsasha928@gmail.com> <4DA59704.8@gmail.com> <4DA5A4E0.7060900@gmail.com> <1302703645.15231.26.camel@jaguar> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Sasha Levin , gorcunov@gmail.com, kvm@vger.kernel.org To: Pekka Enberg Return-path: Received: from mail-pz0-f46.google.com ([209.85.210.46]:33565 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024Ab1DMOON (ORCPT ); Wed, 13 Apr 2011 10:14:13 -0400 Received: by pzk9 with SMTP id 9so228402pzk.19 for ; Wed, 13 Apr 2011 07:14:12 -0700 (PDT) In-Reply-To: <1302703645.15231.26.camel@jaguar> Sender: kvm-owner@vger.kernel.org List-ID: On 04/13/2011 10:07 PM, Pekka Enberg wrote: > On Wed, 2011-04-13 at 16:38 +0300, Sasha Levin wrote: >> On Wed, Apr 13, 2011 at 4:28 PM, Asias He wrote: >>> On 04/13/2011 08:28 PM, Asias He wrote: >>>> On 04/13/2011 08:13 PM, Sasha Levin wrote: >>>>> Add --host-ip-addr parameter to allow changing the host-side IP address. >>>> >>>> >>>> I'd personally prefer something like this: >>>> >>>> --network=model=virtio,hostip=x.x.x.x/mask,guestmac=yy:yy:yy:yy >>>> >>>> Once we can set up ip address for guest, we can use: >>>> >>>> --network=model=virtio,hostip=x.x.x.x/mask,guestmac=yy:yy:yy:yy,guestip=z.z.z.z/mask,guestgw=v.v.v.v >>>> >>> >>> >>> Alternatively, we can use an option group like this: >>> >>> Network options: >>> -n --network >>> -h --hostip >>> -y --guestip >>> -z --guestmac >>> >> >> I agree. We can create a networking group once we start expanding the options. > > Asias, is the patch OK to merge? The first patch is ok. Sasha needs modification for the second patch. -- Best Regards, Asias He