From: Anthony Liguori <anthony@codemonkey.ws>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Pekka Enberg <penberg@kernel.org>,
Prasad Joshi <prasadjoshi124@gmail.com>,
mingo@elte.hu, kvm@vger.kernel.org, asias.hejun@gmail.com,
gorcunov@gmail.com, levinsasha928@gmail.com,
stefanha@linux.vnet.ibm.com
Subject: Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support
Date: Thu, 14 Apr 2011 09:59:35 -0500 [thread overview]
Message-ID: <4DA70BD7.9070803@codemonkey.ws> (raw)
In-Reply-To: <4DA6B5E3.3020508@redhat.com>
On 04/14/2011 03:52 AM, Kevin Wolf wrote:
>
> Well, copying in itself is not a big problem as long as the copies are
> kept in sync. It's a bit painful, but manageable. Implementing every
> image format twice (and implementing image formats in a reliable and
> performing way isn't trivial) is much more painful.
>
> If you take the approach of "getting inspired" by qemu and then writing
> your own code, the code will read pretty much the same, but be different
> enough that a diff between both trees is useless and a patch against one
> tree is meaningless for the other one.
>
> The block drivers are relatively isolated in qemu, so I think they
> wouldn't pull in too many dependencies.
The block layer has some interesting bits though that I can understand
wanting to avoid (like aio emulation).
In the very least, we've learned the hard way that getting an image
format right is very hard. A good test suite is worth it's weight in
gold for something like this. When taking the approach of starting
fresh, doing test driven development is definitely worth considering.
Regards,
Anthony Liguori
> Kevin
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-04-14 14:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 19:26 [PATCH v2] kvm tool: add QCOW verions 1 read/write support Prasad Joshi
2011-04-13 19:48 ` Pekka Enberg
2011-04-14 6:18 ` [PATCH] kvm tool: Remove unused variables from the QCOW code Ingo Molnar
2011-04-14 8:02 ` [PATCH v2] kvm tool: add QCOW verions 1 read/write support Kevin Wolf
2011-04-14 8:07 ` Ingo Molnar
2011-04-14 8:12 ` Kevin Wolf
2011-04-14 8:15 ` Pekka Enberg
2011-04-14 8:26 ` Kevin Wolf
2011-04-14 8:27 ` Ingo Molnar
2011-04-14 9:23 ` Prasad Joshi
2011-04-14 9:28 ` Ingo Molnar
2011-04-14 9:53 ` Pekka Enberg
2011-04-14 8:25 ` Ingo Molnar
2011-04-14 8:21 ` Pekka Enberg
2011-04-14 8:31 ` Kevin Wolf
2011-04-14 8:32 ` Pekka Enberg
2011-04-14 8:49 ` Alon Levy
2011-04-14 8:52 ` Kevin Wolf
2011-04-14 9:26 ` Markus Armbruster
2011-04-14 9:52 ` Kevin Wolf
2011-04-14 10:02 ` Markus Armbruster
2011-04-14 9:53 ` Stefan Hajnoczi
2011-04-14 14:59 ` Anthony Liguori [this message]
2011-04-15 6:41 ` Why QCOW1? (was: [PATCH v2] kvm tool: add QCOW verions 1 read/write support) Markus Armbruster
2011-04-15 6:45 ` Pekka Enberg
2011-04-15 10:14 ` Stefan Hajnoczi
2011-04-15 11:17 ` Pekka Enberg
2011-04-15 12:05 ` Stefan Hajnoczi
2011-04-15 12:10 ` Pekka Enberg
2011-04-15 12:17 ` Why QCOW1? Kevin Wolf
2011-04-15 12:12 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA70BD7.9070803@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox