From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command
Date: Wed, 20 Apr 2011 09:53:56 +0800
Message-ID: <4DAE3CB4.6000302@cn.fujitsu.com>
References: <4D74A8C9.2020408@cn.fujitsu.com>	<4D74A974.6090509@cn.fujitsu.com>	<20110404105949.GA30324@redhat.com>	<m3r59i439t.fsf@blackfin.pond.sub.org> <4D99C309.6060905@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Markus Armbruster <armbru@redhat.com>,
	Lai Jiangshan <eag0628@gmail.com>, kvm@vger.kernel.org,
	qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>,
	Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:57159 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1754493Ab1DTBve (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 19 Apr 2011 21:51:34 -0400
In-Reply-To: <4D99C309.6060905@codemonkey.ws>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 04/04/2011 09:09 PM, Anthony Liguori wrote:
> On 04/04/2011 07:19 AM, Markus Armbruster wrote:
>> [Note cc: Anthony]
>>
>> "Daniel P. Berrange"<berrange@redhat.com>  writes:
>>
>>> On Mon, Mar 07, 2011 at 05:46:28PM +0800, Lai Jiangshan wrote:
>>>> From: Lai Jiangshan<laijs@cn.fujitsu.com>
>>>> Date: Mon, 7 Mar 2011 17:05:15 +0800
>>>> Subject: [PATCH 2/2] qemu,qmp: add inject-nmi qmp command
>>>>
>>>> inject-nmi command injects an NMI on all CPUs of guest.
>>>> It is only supported for x86 guest currently, it will
>>>> returns "Unsupported" error for non-x86 guest.
>>>>
>>>> ---
>>>>   hmp-commands.hx |    2 +-
>>>>   monitor.c       |   18 +++++++++++++++++-
>>>>   qmp-commands.hx |   29 +++++++++++++++++++++++++++++
>>>>   3 files changed, 47 insertions(+), 2 deletions(-)
>>> Does anyone have any feedback on this addition, or are all new
>>> QMP patch proposals blocked pending Anthony's QAPI work ?
>> That would be bad.  Anthony, what's holding this back?
> 
> It doesn't pass checkpath.pl.
> 
> But I'd also expect this to come through Luiz's QMP tree.
> 
> Regards,
> 
> Anthony Liguori
> 

Hi, Anthony,

I cannot find checkpath.pl in the source tree.
And how/where to write errors descriptions? Is the following description
suitable?

##
# @inject-nmi:
#
# Inject an NMI on the guest.
#
# Returns: Nothing on success.
#          If the guest(non-x86) does not support NMI injection, Unsupported
#
# Since: 0.15.0
##
{ 'command': 'inject-nmi' }


Thanks,
Lai