From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lai Jiangshan Subject: Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command Date: Wed, 20 Apr 2011 11:02:49 +0800 Message-ID: <4DAE4CD9.2080008@cn.fujitsu.com> References: <4D74A8C9.2020408@cn.fujitsu.com> <4D74A974.6090509@cn.fujitsu.com> <20110404105949.GA30324@redhat.com> <4D99C309.6060905@codemonkey.ws> <4DAE3CB4.6000302@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Markus Armbruster , Lai Jiangshan , kvm@vger.kernel.org, qemu-devel@nongnu.org, Luiz Capitulino , Avi Kivity To: Anthony Liguori Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:51569 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752907Ab1DTDA3 (ORCPT ); Tue, 19 Apr 2011 23:00:29 -0400 In-Reply-To: <4DAE3CB4.6000302@cn.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/20/2011 09:53 AM, Lai Jiangshan wrote: > On 04/04/2011 09:09 PM, Anthony Liguori wrote: >> On 04/04/2011 07:19 AM, Markus Armbruster wrote: >>> [Note cc: Anthony] >>> >>> "Daniel P. Berrange" writes: >>> >>>> On Mon, Mar 07, 2011 at 05:46:28PM +0800, Lai Jiangshan wrote: >>>>> From: Lai Jiangshan >>>>> Date: Mon, 7 Mar 2011 17:05:15 +0800 >>>>> Subject: [PATCH 2/2] qemu,qmp: add inject-nmi qmp command >>>>> >>>>> inject-nmi command injects an NMI on all CPUs of guest. >>>>> It is only supported for x86 guest currently, it will >>>>> returns "Unsupported" error for non-x86 guest. >>>>> >>>>> --- >>>>> hmp-commands.hx | 2 +- >>>>> monitor.c | 18 +++++++++++++++++- >>>>> qmp-commands.hx | 29 +++++++++++++++++++++++++++++ >>>>> 3 files changed, 47 insertions(+), 2 deletions(-) >>>> Does anyone have any feedback on this addition, or are all new >>>> QMP patch proposals blocked pending Anthony's QAPI work ? >>> That would be bad. Anthony, what's holding this back? >> >> It doesn't pass checkpath.pl. >> >> But I'd also expect this to come through Luiz's QMP tree. >> >> Regards, >> >> Anthony Liguori >> > > Hi, Anthony, > > I cannot find checkpath.pl in the source tree. Sorry, I found it in the mainline tree. > And how/where to write errors descriptions? Is the following description > suitable? > > ## > # @inject-nmi: > # > # Inject an NMI on the guest. > # > # Returns: Nothing on success. > # If the guest(non-x86) does not support NMI injection, Unsupported > # > # Since: 0.15.0 > ## > { 'command': 'inject-nmi' } > > > Thanks, > Lai > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >