From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] acpi_piix4: remove bad save/restore of cpus_sts
Date: Wed, 20 Apr 2011 11:24:25 +0300
Message-ID: <4DAE9839.1020902@redhat.com>
References: <1303116256-10898-1-git-send-email-avi@redhat.com> <20110418135658.GE21865@valinux.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org,
	Juan Quintela <quintela@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:59865 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751867Ab1DTIYb (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 20 Apr 2011 04:24:31 -0400
In-Reply-To: <20110418135658.GE21865@valinux.co.jp>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 04/18/2011 04:56 PM, Isaku Yamahata wrote:
> This patch would fix the segfaults. But I suppose the followings
> are necessary.
>
> - PIIX4PMState::gpe_cpu needs to be saved/loaded somewhere

Yes.  Juan?

> - gpe_writeb() needs to handle PROC_BASE ... PROC_BASE+31
>    like gpe_readb(). To be honest, I don't see why gpe_readb/writeb()
>    are used for PROC_BASE...PROC_BASE + 31
>

Even before the merge, we didn't handle a write to this address.  
Perhaps it's read-only? (that should explain no save/restore).

-- 
error compiling committee.c: too many arguments to function