From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2] KVM: emulator: Use linearize() when fetching instructions. Date: Wed, 20 Apr 2011 16:04:44 +0300 Message-ID: <4DAED9EC.5080604@redhat.com> References: <1303142753-24562-1-git-send-email-nelhage@ksplice.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Nelson Elhage Return-path: In-Reply-To: <1303142753-24562-1-git-send-email-nelhage@ksplice.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 04/18/2011 07:05 PM, Nelson Elhage wrote: > Since segments need to be handled slightly differently when fetching > instructions, we add a __linearize helper that accepts a new 'fetch' boolean. > static int segmented_read_std(struct x86_emulate_ctxt *ctxt, > struct segmented_address addr, > void *data, > @@ -637,11 +646,13 @@ static int do_fetch_insn_byte(struct x86_emulate_ctxt *ctxt, > int size, cur_size; > > if (eip == fc->end) { > - unsigned long linear = eip + ctxt->cs_base; > - if (ctxt->mode != X86EMUL_MODE_PROT64) > - linear&= (u32)-1; > + unsigned long linear; > + struct segmented_address addr = {VCPU_SREG_CS, eip}; > cur_size = fc->end - fc->start; > size = min(15UL - cur_size, PAGE_SIZE - offset_in_page(eip)); Breaks immediately - the segmented_address initializer is backwards. I've fixed this in my tree. -- error compiling committee.c: too many arguments to function