From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: MMU: Make cmpxchg_gpte aware of nesting too Date: Thu, 21 Apr 2011 11:11:19 +0300 Message-ID: <4DAFE6A7.2010700@redhat.com> References: <20110419033220.e527bcae.takuya.yoshikawa@gmail.com> <20110419033453.ffa856c9.takuya.yoshikawa@gmail.com> <4DAEA240.9020104@redhat.com> <20110420093515.GX2192@amd.com> <4DAEAFD4.1050609@redhat.com> <20110420110630.GZ2192@amd.com> <4DAEC0F4.70201@redhat.com> <20110420133316.GA2192@amd.com> <20110421100210.b704066f.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Roedel, Joerg" , Takuya Yoshikawa , "mtosatti@redhat.com" , "kvm@vger.kernel.org" To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:28911 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752966Ab1DUIL2 (ORCPT ); Thu, 21 Apr 2011 04:11:28 -0400 In-Reply-To: <20110421100210.b704066f.yoshikawa.takuya@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 04/21/2011 04:02 AM, Takuya Yoshikawa wrote: > On Wed, 20 Apr 2011 15:33:16 +0200 > "Roedel, Joerg" wrote: > > > @@ -245,13 +257,17 @@ walk: > > goto error; > > > > if (write_fault&& !is_dirty_gpte(pte)) { > > - bool ret; > > + int ret; > > > > trace_kvm_mmu_set_dirty_bit(table_gfn, index, sizeof(pte)); > > - ret = FNAME(cmpxchg_gpte)(vcpu->kvm, table_gfn, index, pte, > > + ret = FNAME(cmpxchg_gpte)(vcpu, mmu, table_gfn, index, pte, > > pte|PT_DIRTY_MASK); > > - if (ret) > > + if (ret< 0) { > > + present = false; > > + goto error; > > + } if (ret) > > goto walk; > > Preferably else if or another line ? :) Yes, I added an 'else' and applied. Thanks. -- error compiling committee.c: too many arguments to function