From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@siemens.com>
Subject: =?windows-1252?Q?Re=3A_Failure_to_compile_latest_git_?=
 =?windows-1252?Q?=28target-i386/kvm=2Ec=3A953=3A29=3A_error=3A_varia?=
 =?windows-1252?Q?ble_=91fop=92_set_but_not_used=29?=
Date: Thu, 21 Apr 2011 17:43:02 +0200
Message-ID: <4DB05086.7050609@siemens.com>
References: <4DB03AC4.1070907@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: qemu-devel@nongnu.org, kvm <kvm@vger.kernel.org>,
	Avi Kivity <avi@redhat.com>
To: Yaniv Kaul <ykaul@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from fmmailgate01.web.de ([217.72.192.221]:46482 "EHLO
	fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750915Ab1DUPnn (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 21 Apr 2011 11:43:43 -0400
In-Reply-To: <4DB03AC4.1070907@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 2011-04-21 16:10, Yaniv Kaul wrote:
> Fedora 15beta/x64, latest git:
> [ykaul@ykaul qemu]$ make
>   CC    x86_64-softmmu/kvm.o
> /home/ykaul/qemu/target-i386/kvm.c: In function =91kvm_get_xsave=92:
> /home/ykaul/qemu/target-i386/kvm.c:953:29: error: variable =91fop=92 =
set but
> not used [-Werror=3Dunused-but-set-variable]
> cc1: all warnings being treated as errors
>=20
> make[1]: *** [kvm.o] Error 1
> make: *** [subdir-x86_64-softmmu] Error 2
>=20

This one looks a bit suspicious:

Avi, why do we have kvm_fpu::last_* in the ABI, copying that informatio=
n
from/to user land, but do not handle it otherwise? To my understanding
this fop here in xsave corresponds to kvm_fpu::last_opcode in the
SET/GET_FPU case, right? It's set to 0 on SET_XSAVE and ignored on
GET_XSAVE as this warnings tells us.

Jan

--=20
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux