* [PATCH] KVM: x86 emulator: avoid calling wbinvd() macro
@ 2011-04-21 19:16 Clemens Noss
2011-04-24 6:57 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Clemens Noss @ 2011-04-21 19:16 UTC (permalink / raw)
To: kvm; +Cc: avi
Commit 0b56652e33c72092956c651ab6ceb9f0ad081153 fails to build:
CC [M] arch/x86/kvm/emulate.o
arch/x86/kvm/emulate.c: In function 'x86_emulate_insn':
arch/x86/kvm/emulate.c:4095:25: error: macro "wbinvd" passed 1 arguments, but takes just 0
arch/x86/kvm/emulate.c:4095:3: warning: statement with no effect
make[2]: *** [arch/x86/kvm/emulate.o] Error 1
make[1]: *** [arch/x86/kvm] Error 2
make: *** [arch/x86] Error 2
Work around this for now.
Signed-off-by: Clemens Noss <cnoss@gmx.de>
---
arch/x86/kvm/emulate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index f683ce1..97b1a29 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -4092,7 +4092,7 @@ twobyte_insn:
rc = em_clts(ctxt);
break;
case 0x09: /* wbinvd */
- ctxt->ops->wbinvd(ctxt);
+ (ctxt->ops->wbinvd)(ctxt);
break;
case 0x08: /* invd */
case 0x0d: /* GrpP (prefetch) */
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: x86 emulator: avoid calling wbinvd() macro
2011-04-21 19:16 [PATCH] KVM: x86 emulator: avoid calling wbinvd() macro Clemens Noss
@ 2011-04-24 6:57 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2011-04-24 6:57 UTC (permalink / raw)
To: Clemens Noss; +Cc: kvm
On 04/21/2011 10:16 PM, Clemens Noss wrote:
> Commit 0b56652e33c72092956c651ab6ceb9f0ad081153 fails to build:
>
> CC [M] arch/x86/kvm/emulate.o
> arch/x86/kvm/emulate.c: In function 'x86_emulate_insn':
> arch/x86/kvm/emulate.c:4095:25: error: macro "wbinvd" passed 1 arguments, but takes just 0
> arch/x86/kvm/emulate.c:4095:3: warning: statement with no effect
> make[2]: *** [arch/x86/kvm/emulate.o] Error 1
> make[1]: *** [arch/x86/kvm] Error 2
> make: *** [arch/x86] Error 2
>
> Work around this for now.
Applied, thanks.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-24 6:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-21 19:16 [PATCH] KVM: x86 emulator: avoid calling wbinvd() macro Clemens Noss
2011-04-24 6:57 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).