kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org,
	yoshikawa.takuya@oss.ntt.co.jp, xiaoguangrong@cn.fujitsu.com,
	Joerg.Roedel@amd.com
Subject: Re: [PATCH 1/1 v2] KVM: MMU: Optimize guest page table walk
Date: Sun, 24 Apr 2011 10:27:06 +0300	[thread overview]
Message-ID: <4DB3D0CA.6050007@redhat.com> (raw)
In-Reply-To: <20110422003444.5b3a876a.takuya.yoshikawa@gmail.com>

On 04/21/2011 06:34 PM, Takuya Yoshikawa wrote:
> From: Takuya Yoshikawa<yoshikawa.takuya@oss.ntt.co.jp>
>
> This patch optimizes the guest page table walk by using get_user()
> instead of copy_from_user().
>
> With this patch applied, paging64_walk_addr_generic() has become
> about 0.5us to 1.0us faster on my Phenom II machine with NPT on.

Applied, thanks.  Care to send a follow-on patch that makes 
cmpxchg_gpte() use ptep_user instead of calculating it by itself?

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


  reply	other threads:[~2011-04-24  7:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-21 15:32 [PATCH 0/1 v2] KVM: MMU: Optimize guest page table walk Takuya Yoshikawa
2011-04-21 15:34 ` [PATCH 1/1 " Takuya Yoshikawa
2011-04-24  7:27   ` Avi Kivity [this message]
2011-04-24 13:15     ` Takuya Yoshikawa
2011-04-25  8:04   ` Jan Kiszka
2011-04-25  8:32     ` Takuya Yoshikawa
2011-04-25  9:15       ` Jan Kiszka
2011-04-26  4:50         ` Takuya Yoshikawa
2011-04-26  6:34           ` Jan Kiszka
2011-04-26 14:40             ` Takuya Yoshikawa
2011-04-26 14:54               ` Avi Kivity
2011-04-26 15:13                 ` Takuya Yoshikawa
2011-04-26 17:15                   ` Avi Kivity
2011-04-26 16:26                 ` Takuya Yoshikawa
2011-04-26 17:16                   ` Avi Kivity
2011-04-26  7:42     ` Avi Kivity
2011-04-26  7:45       ` Jan Kiszka
2011-04-26  8:21         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB3D0CA.6050007@redhat.com \
    --to=avi@redhat.com \
    --cc=Joerg.Roedel@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=takuya.yoshikawa@gmail.com \
    --cc=xiaoguangrong@cn.fujitsu.com \
    --cc=yoshikawa.takuya@oss.ntt.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).