From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 1/1 v2] KVM: MMU: Optimize guest page table walk Date: Mon, 25 Apr 2011 11:15:20 +0200 Message-ID: <4DB53BA8.60401@web.de> References: <20110422003222.9d08aee3.takuya.yoshikawa@gmail.com> <20110422003444.5b3a876a.takuya.yoshikawa@gmail.com> <4DB52B1B.5080407@web.de> <20110425173215.740417ae.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig545C044332F1BB3EE9D7FE9F" Cc: Takuya Yoshikawa , avi@redhat.com, mtosatti@redhat.com, kvm@vger.kernel.org, xiaoguangrong@cn.fujitsu.com, Joerg.Roedel@amd.com To: Takuya Yoshikawa Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:41124 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758131Ab1DYJP0 (ORCPT ); Mon, 25 Apr 2011 05:15:26 -0400 In-Reply-To: <20110425173215.740417ae.yoshikawa.takuya@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig545C044332F1BB3EE9D7FE9F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-04-25 10:32, Takuya Yoshikawa wrote: > On Mon, 25 Apr 2011 10:04:43 +0200 > Jan Kiszka wrote: >=20 >>> + >>> + ptep_user =3D (pt_element_t __user *)((void *)host_addr + offset);= >>> + if (get_user(pte, ptep_user)) { >> ^^^^^^^^^^^^ >> This doesn't work for x86-32: pte is 64 bit, but get_user is only >> defined up to 32 bit on that platform. >> >> Avi, what's your 32-bit buildbot doing? :) >> >> Jan >> >=20 > Sorry, I did not test on x86_32. >=20 > Introducing a wrapper function with ifdef would be the best way? >=20 Maybe you could also add the missing 64-bit get_user for x86-32. Given that we have a corresponding put_user, I wonder why the get_user was left out. Jan --------------enig545C044332F1BB3EE9D7FE9F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk21O6wACgkQitSsb3rl5xRhswCcDKuAMHcb6uMeUL7UiUMUhKes G+YAnjcWqvCRSJ7PMrHt3lNK6EgQitxd =SJYX -----END PGP SIGNATURE----- --------------enig545C044332F1BB3EE9D7FE9F--