From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Roth Subject: Re: [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command Date: Mon, 25 Apr 2011 12:07:20 -0500 Message-ID: <4DB5AA48.1010007@linux.vnet.ibm.com> References: <4D74A8C9.2020408@cn.fujitsu.com> <4D74A974.6090509@cn.fujitsu.com> <20110404105949.GA30324@redhat.com> <4D99BF99.1040305@redhat.com> <4D99C22C.4070401@codemonkey.ws> <20110406144723.45333682@doriath> <4D9CAAF9.7000509@codemonkey.ws> <20110406150818.56707b9b@doriath> <4DAE7AF4.3050508@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Luiz Capitulino , Lai Jiangshan , kvm@vger.kernel.org, qemu-devel@nongnu.org, Markus Armbruster , Avi Kivity To: Lai Jiangshan Return-path: Received: from e33.co.us.ibm.com ([32.97.110.151]:55900 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753369Ab1DYRHu (ORCPT ); Mon, 25 Apr 2011 13:07:50 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e33.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p3PH0plQ025640 for ; Mon, 25 Apr 2011 11:00:51 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p3PH7iOE142138 for ; Mon, 25 Apr 2011 11:07:45 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p3PH7FIE004749 for ; Mon, 25 Apr 2011 11:07:17 -0600 In-Reply-To: <4DAE7AF4.3050508@cn.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/20/2011 01:19 AM, Lai Jiangshan wrote: > > > These patches are applied for "http://repo.or.cz/r/qemu/aliguori.git glib". > > These patches add QAPI inject-nmi. They are passed checkpatch.pl and the build. > > But the result qemu executable file is not tested, because the result > qemu of "http://repo.or.cz/r/qemu/aliguori.git glib" can't work in my box. What issues are you seeing using the binary from the glib tree? AFAIK that tree should be functional, except potentially with TCG. I've only been using it with KVM and --enable-io-thread though so don't know for sure. > > Lai Jiangshan (3): > QError: Introduce QERR_UNSUPPORTED > qapi,nmi: add inject-nmi qmp command > qapi-hmp: Convert HMP nmi to use QMP > > hmp-commands.hx | 18 ++++++++---------- > hmp.c | 12 ++++++++++++ > hmp.h | 1 + > monitor.c | 14 -------------- > qapi-schema.json | 12 ++++++++++++ > qerror.c | 4 ++++ > qerror.h | 3 +++ > qmp.c | 17 +++++++++++++++++ > 8 files changed, 57 insertions(+), 24 deletions(-) >