From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: pci passthrough - VF reset at boot is dropping assigned MAC Date: Mon, 25 Apr 2011 15:17:28 -0600 Message-ID: <4DB5E4E8.7000700@gmail.com> References: <4DB5A13B.4050804@gmail.com> <1303749455.3431.21.camel@x201> <4DB5A44F.6040304@gmail.com> <1303752659.3431.31.camel@x201> <4DB5B7AE.8010900@gmail.com> <1303756594.3431.55.camel@x201> <4DB5C78A.1030505@gmail.com> <1303759116.3431.59.camel@x201> <4DB5D9A9.4040503@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: KVM mailing list To: Alex Williamson Return-path: Received: from mail-px0-f179.google.com ([209.85.212.179]:61305 "EHLO mail-px0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046Ab1DYVRc (ORCPT ); Mon, 25 Apr 2011 17:17:32 -0400 Received: by pxi2 with SMTP id 2so19135pxi.10 for ; Mon, 25 Apr 2011 14:17:31 -0700 (PDT) In-Reply-To: <4DB5D9A9.4040503@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/25/11 14:29, David Ahern wrote: > > > On 04/25/11 13:18, Alex Williamson wrote: >>>> I don't see this happening on my system, once manually set the mac never >>>> changes. I can restart and reset the VM and the host and guest both >>>> continue seeing the set mac address. I tested it with both a recent >>>> rhel6.1 host kernel as well as upstream 2.6.39-rc4. If I switch to a VF >>>> with an unset mac, those will change on each VM reset or restart. >>> >>> Blacklist igbvf in the host and you will. That must be the difference: I >>> was preventing the vf driver from loading in the host -- it's not needed >>> there, so why load it? >> >> I already have it blacklisted. It's not needed if you're using the VFs >> they way we are, but there are other uses. >> >>> I rebooted for a fresh run. Loaded the igbvf driver before starting the >>> VM using my tools. With the igbvf driver loaded in the host the MAC >>> address for the VF was not reset. >>> >>> As for why I blacklisted it -- udev. What a PITA with VFs. I saw the >>> feature for Fedora 15 which should address this. >> >> Yes, my VM is up to renaming the VFs eth1340 since the mac changes every >> boot. I'm still confused though as I did a whole round of testing after >> a reboot where igbvf was never loaded and the set mac address stuck >> across VM restarts and resets. >> >> Alex >> > > The resetting of the VM MAC address is fixed in 2.6.39-rc4, so it's a > Fedora 14, 2.6.35.12 problem. Just to finish this off. This is the patch that fixed the MAC address reset problem: commit a6b5ea353845b3f3d9ac4317c0b3be9cc37c259b Author: Greg Rose Date: Sat Nov 6 05:42:59 2010 +0000 igb: Warn on attempt to override administratively set MAC/VLAN Print a warning message to the system log when the VF attempts to override administratively set MAC/VLAN configuration. Signed-off-by: Greg Rose Signed-off-by: Jeff Kirsher David