From: Jan Kiszka <jan.kiszka@web.de>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>,
avi@redhat.com, mtosatti@redhat.com, kvm@vger.kernel.org,
xiaoguangrong@cn.fujitsu.com, Joerg.Roedel@amd.com
Subject: Re: [PATCH 1/1 v2] KVM: MMU: Optimize guest page table walk
Date: Tue, 26 Apr 2011 08:34:57 +0200 [thread overview]
Message-ID: <4DB66791.50403@web.de> (raw)
In-Reply-To: <20110426135035.5f569397.yoshikawa.takuya@oss.ntt.co.jp>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
On 2011-04-26 06:50, Takuya Yoshikawa wrote:
> On Mon, 25 Apr 2011 11:15:20 +0200
> Jan Kiszka <jan.kiszka@web.de> wrote:
>
>>> Sorry, I did not test on x86_32.
>>>
>>> Introducing a wrapper function with ifdef would be the best way?
>>>
>>
>> Maybe you could also add the missing 64-bit get_user for x86-32. Given
>> that we have a corresponding put_user, I wonder why the get_user was
>> left out.
>>
>> Jan
>>
>
> Google said that there was a similar talk on LKML in 2004.
>
> On that threads, Linus explained how to tackle on the 64-bit get_user
> implementation. But I could not see what happened after that.
Mmh, maybe the kernel was lacking a real use case, so no one seriously
cared.
I don't see a fundamental blocker for an x86-32 __get_user_8 version
based on two mov. I would give it a try.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2011-04-26 6:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 15:32 [PATCH 0/1 v2] KVM: MMU: Optimize guest page table walk Takuya Yoshikawa
2011-04-21 15:34 ` [PATCH 1/1 " Takuya Yoshikawa
2011-04-24 7:27 ` Avi Kivity
2011-04-24 13:15 ` Takuya Yoshikawa
2011-04-25 8:04 ` Jan Kiszka
2011-04-25 8:32 ` Takuya Yoshikawa
2011-04-25 9:15 ` Jan Kiszka
2011-04-26 4:50 ` Takuya Yoshikawa
2011-04-26 6:34 ` Jan Kiszka [this message]
2011-04-26 14:40 ` Takuya Yoshikawa
2011-04-26 14:54 ` Avi Kivity
2011-04-26 15:13 ` Takuya Yoshikawa
2011-04-26 17:15 ` Avi Kivity
2011-04-26 16:26 ` Takuya Yoshikawa
2011-04-26 17:16 ` Avi Kivity
2011-04-26 7:42 ` Avi Kivity
2011-04-26 7:45 ` Jan Kiszka
2011-04-26 8:21 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB66791.50403@web.de \
--to=jan.kiszka@web.de \
--cc=Joerg.Roedel@amd.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=xiaoguangrong@cn.fujitsu.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).