From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 1/1 v2] KVM: MMU: Optimize guest page table walk Date: Tue, 26 Apr 2011 08:34:57 +0200 Message-ID: <4DB66791.50403@web.de> References: <20110422003222.9d08aee3.takuya.yoshikawa@gmail.com> <20110422003444.5b3a876a.takuya.yoshikawa@gmail.com> <4DB52B1B.5080407@web.de> <20110425173215.740417ae.yoshikawa.takuya@oss.ntt.co.jp> <4DB53BA8.60401@web.de> <20110426135035.5f569397.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigAD9B362687C57EBCA9750B8B" Cc: Takuya Yoshikawa , avi@redhat.com, mtosatti@redhat.com, kvm@vger.kernel.org, xiaoguangrong@cn.fujitsu.com, Joerg.Roedel@amd.com To: Takuya Yoshikawa Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:54980 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756489Ab1DZGfM (ORCPT ); Tue, 26 Apr 2011 02:35:12 -0400 In-Reply-To: <20110426135035.5f569397.yoshikawa.takuya@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigAD9B362687C57EBCA9750B8B Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-04-26 06:50, Takuya Yoshikawa wrote: > On Mon, 25 Apr 2011 11:15:20 +0200 > Jan Kiszka wrote: >=20 >>> Sorry, I did not test on x86_32. >>> >>> Introducing a wrapper function with ifdef would be the best way? >>> >> >> Maybe you could also add the missing 64-bit get_user for x86-32. Given= >> that we have a corresponding put_user, I wonder why the get_user was >> left out. >> >> Jan >> >=20 > Google said that there was a similar talk on LKML in 2004. >=20 > On that threads, Linus explained how to tackle on the 64-bit get_user > implementation. But I could not see what happened after that. Mmh, maybe the kernel was lacking a real use case, so no one seriously cared. I don't see a fundamental blocker for an x86-32 __get_user_8 version based on two mov. I would give it a try. Jan --------------enigAD9B362687C57EBCA9750B8B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk22Z50ACgkQitSsb3rl5xTaVwCfViJi9LXSiuwKGnqHmsz3O3Lb zvUAoOPvo1ZTmK3yeJCyo5pEr0GNF1Gd =PE1U -----END PGP SIGNATURE----- --------------enigAD9B362687C57EBCA9750B8B--