From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: kvm crashes with spice while loading qxl
Date: Tue, 26 Apr 2011 11:43:27 +0200
Message-ID: <4DB693BF.1020202@redhat.com>
References: <AANLkTint9-P-1jD5pbXstzPcYueLHQ68Rd0T_Chz6xRN@mail.gmail.com> <4D68F20D.2020401@web.de> <4DB687F0.20605@redhat.com> <4DB68B05.1090600@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: xming <xmingske@gmail.com>, kvm@vger.kernel.org,
	qemu-devel <qemu-devel@nongnu.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:25010 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752043Ab1DZJno (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 26 Apr 2011 05:43:44 -0400
In-Reply-To: <4DB68B05.1090600@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 04/26/11 11:06, Jan Kiszka wrote:
> On 2011-04-26 10:53, Gerd Hoffmann wrote:
>>> Two general issues with dropping the global mutex like this:
>>>    - The caller of mutex_unlock is responsible for maintaining
>>>      cpu_single_env across the unlocked phase (that's related to the
>>>      abort above).
>>
>> This is true for qemu-kvm only, right?
>
> Nope, this applies to both implementations.

Oops.

>> qemu-kvm specific patches which add the cpu_single_env tracking (not
>> polished yet) are here:
>>
>> http://cgit.freedesktop.org/spice/qemu/log/?h=spice.kvm.v28
>
> Cannot spot that quickly: In which way are they specific to qemu-kvm?

cpu_single_env bookeeping.  But if upstream needs that too having 
specific patches is pretty pointless.  I'll go fix it up upstream then.

cheers,
   Gerd