From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 9/9] qemu-kvm: hpet: Add MSI support for in-kernel irqchip mode Date: Tue, 26 Apr 2011 16:56:57 +0300 Message-ID: <4DB6CF29.1030100@redhat.com> References: <3d089633897515a214af032ed633342a7001945f.1303823975.git.jan.kiszka@siemens.com> <4DB6C90F.4090401@msgid.tls.msk.ru> <4DB6CEDB.8000200@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Michael Tokarev , Marcelo Tosatti , "kvm@vger.kernel.org" , "Michael S. Tsirkin" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:12826 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754759Ab1DZN5S (ORCPT ); Tue, 26 Apr 2011 09:57:18 -0400 In-Reply-To: <4DB6CEDB.8000200@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/26/2011 04:55 PM, Jan Kiszka wrote: > On 2011-04-26 15:30, Michael Tokarev wrote: > > 26.04.2011 17:19, Jan Kiszka wrote: > > > >> hw/hpet.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > > > >> +static int modifying_bit(uint64_t old, uint64_t new, uint64_t mask) > >> +{ > >> + return (old ^ new)& mask; > >> +} > > > > Such constructs always look suspicious. I'm not even sure anymore > > (after using C for over 20 years ;) that this works... how about > > > > return (old ^ new)& mask ? 1 : 0; > > > > instead, or something along this? I mean, if sizeof(int)==4, how > > `return 1ULL<<32' will be interpreted in this context? Tiny test > > program tells me it will return 0... > > Good catch, will fix (doesn't bite use here, flags fit into 32 bit, but > nevertheless). > Note, a bool return type works here. -- error compiling committee.c: too many arguments to function