From: Jan Kiszka <jan.kiszka@siemens.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v3 9/9] qemu-kvm: hpet: Add MSI support for in-kernel irqchip mode
Date: Tue, 26 Apr 2011 19:06:34 +0200 [thread overview]
Message-ID: <4DB6FB9A.10907@siemens.com> (raw)
In-Reply-To: <20110426160602.GA1048@infradead.org>
On 2011-04-26 18:06, Christoph Hellwig wrote:
> On Tue, Apr 26, 2011 at 04:01:00PM +0200, Jan Kiszka wrote:
>> +static bool modifying_bit(uint64_t old, uint64_t new, uint64_t mask)
>> +{
>> + return (old ^ new) & mask;
>> +}
>> +
>
> A more usual name would be toggle_bit. But you're passing in a mask
> to be modified, so it would be more a toggle_bits or toggle_mask.
>
This function is checking for a change. But I've no problem renaming it
to toggling_bit or so if that's preferred.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2011-04-26 17:06 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 13:19 [PATCH v2 0/9] qemu-kvm: Clean up and enhance MSI irqchip support Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 1/9] qemu-kvm: Drop unneeded kvm_irq_routing_entry declaration Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 2/9] qemu-kvm: Rename kvm_msix_message to KVMMsiMessage Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 3/9] qemu-kvm: Refactor MSI core API of KVM Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 4/9] qemu-kvm: Fix and clean up msix vector use/unuse hooks Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 5/9] qemu-kvm: Move gsi bits from kvm_msix_vector_add to kvm_msi_add_message Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 6/9] qemu-kvm: Move entry comparison into kvm_msi_update_message Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 7/9] qemu-kvm: Add in-kernel irqchip support for MSI Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 8/9] qemu-kvm: Refresh MSI settings after vmload Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 9/9] qemu-kvm: hpet: Add MSI support for in-kernel irqchip mode Jan Kiszka
2011-04-26 13:30 ` Michael Tokarev
2011-04-26 13:55 ` Jan Kiszka
2011-04-26 13:56 ` Avi Kivity
2011-04-26 13:58 ` Jan Kiszka
2011-04-26 14:01 ` [PATCH v3 " Jan Kiszka
2011-04-26 16:06 ` Christoph Hellwig
2011-04-26 17:06 ` Jan Kiszka [this message]
2011-04-26 17:09 ` Christoph Hellwig
2011-04-27 7:27 ` [PATCH v2 0/9] qemu-kvm: Clean up and enhance MSI irqchip support Avi Kivity
2011-04-27 9:00 ` Jan Kiszka
2011-04-27 9:04 ` Avi Kivity
2011-04-27 9:06 ` Jan Kiszka
2011-04-27 9:14 ` Avi Kivity
2011-04-27 11:21 ` Jan Kiszka
2011-04-27 12:12 ` Avi Kivity
2011-04-27 13:31 ` Jan Kiszka
2011-04-27 13:39 ` Avi Kivity
2011-04-27 13:54 ` Jan Kiszka
2011-04-27 14:01 ` Avi Kivity
2011-04-27 14:11 ` Michael S. Tsirkin
2011-04-27 14:02 ` Michael S. Tsirkin
2011-04-27 14:10 ` Jan Kiszka
2011-04-27 14:14 ` Michael S. Tsirkin
2011-04-27 14:21 ` Jan Kiszka
2011-04-27 13:49 ` Michael S. Tsirkin
2011-04-27 9:34 ` Avi Kivity
2011-04-27 11:39 ` [PATCH v2 8/9] qemu-kvm: Refresh MSI settings after vmload Jan Kiszka
2011-04-27 12:19 ` Avi Kivity
2011-04-27 14:16 ` Michael S. Tsirkin
2011-04-27 14:28 ` Jan Kiszka
2011-04-27 14:30 ` Michael S. Tsirkin
2011-04-27 14:39 ` Jan Kiszka
2011-04-27 15:09 ` Michael S. Tsirkin
2011-04-27 15:21 ` Jan Kiszka
2011-04-27 16:02 ` Michael S. Tsirkin
2011-04-27 16:20 ` Jan Kiszka
2011-04-27 16:26 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB6FB9A.10907@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=avi@redhat.com \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox