From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Cc: Jan Kiszka <jan.kiszka@web.de>,
Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>,
mtosatti@redhat.com, kvm@vger.kernel.org,
xiaoguangrong@cn.fujitsu.com, Joerg.Roedel@amd.com
Subject: Re: [PATCH 1/1 v2] KVM: MMU: Optimize guest page table walk
Date: Tue, 26 Apr 2011 20:15:12 +0300 [thread overview]
Message-ID: <4DB6FDA0.8000200@redhat.com> (raw)
In-Reply-To: <20110427001306.0f6eb09f.takuya.yoshikawa@gmail.com>
On 04/26/2011 06:13 PM, Takuya Yoshikawa wrote:
> > Please post a simple patch that uses two get_user()s for that case
> > (64-bit pte on 32-bit host). Then work with the x86 tree to see if
> > they'll accept 64-bit get_user(), and once they do, we can go back to a
> > simple get_user() again.
> >
> > btw, I think we can use __get_user() here since the address must have
> > been already validated.
>
> Yes, I thought that at first.
>
> But don't we need to care KVM's address translation bugs?
It's a pity to do a runtime check when we can do a setup time check
instead. So let's review the setup code and then use __get_user().
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-04-26 17:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 15:32 [PATCH 0/1 v2] KVM: MMU: Optimize guest page table walk Takuya Yoshikawa
2011-04-21 15:34 ` [PATCH 1/1 " Takuya Yoshikawa
2011-04-24 7:27 ` Avi Kivity
2011-04-24 13:15 ` Takuya Yoshikawa
2011-04-25 8:04 ` Jan Kiszka
2011-04-25 8:32 ` Takuya Yoshikawa
2011-04-25 9:15 ` Jan Kiszka
2011-04-26 4:50 ` Takuya Yoshikawa
2011-04-26 6:34 ` Jan Kiszka
2011-04-26 14:40 ` Takuya Yoshikawa
2011-04-26 14:54 ` Avi Kivity
2011-04-26 15:13 ` Takuya Yoshikawa
2011-04-26 17:15 ` Avi Kivity [this message]
2011-04-26 16:26 ` Takuya Yoshikawa
2011-04-26 17:16 ` Avi Kivity
2011-04-26 7:42 ` Avi Kivity
2011-04-26 7:45 ` Jan Kiszka
2011-04-26 8:21 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB6FDA0.8000200@redhat.com \
--to=avi@redhat.com \
--cc=Joerg.Roedel@amd.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=xiaoguangrong@cn.fujitsu.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).