From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/1 v2] KVM: MMU: Optimize guest page table walk Date: Tue, 26 Apr 2011 20:15:12 +0300 Message-ID: <4DB6FDA0.8000200@redhat.com> References: <20110422003222.9d08aee3.takuya.yoshikawa@gmail.com> <20110422003444.5b3a876a.takuya.yoshikawa@gmail.com> <4DB52B1B.5080407@web.de> <20110425173215.740417ae.yoshikawa.takuya@oss.ntt.co.jp> <4DB53BA8.60401@web.de> <20110426135035.5f569397.yoshikawa.takuya@oss.ntt.co.jp> <4DB66791.50403@web.de> <20110426234034.ab2ed524.takuya.yoshikawa@gmail.com> <4DB6DCA0.1000303@redhat.com> <20110427001306.0f6eb09f.takuya.yoshikawa@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , Takuya Yoshikawa , mtosatti@redhat.com, kvm@vger.kernel.org, xiaoguangrong@cn.fujitsu.com, Joerg.Roedel@amd.com To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45660 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753863Ab1DZRP2 (ORCPT ); Tue, 26 Apr 2011 13:15:28 -0400 In-Reply-To: <20110427001306.0f6eb09f.takuya.yoshikawa@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/26/2011 06:13 PM, Takuya Yoshikawa wrote: > > Please post a simple patch that uses two get_user()s for that case > > (64-bit pte on 32-bit host). Then work with the x86 tree to see if > > they'll accept 64-bit get_user(), and once they do, we can go back to a > > simple get_user() again. > > > > btw, I think we can use __get_user() here since the address must have > > been already validated. > > Yes, I thought that at first. > > But don't we need to care KVM's address translation bugs? It's a pity to do a runtime check when we can do a setup time check instead. So let's review the setup code and then use __get_user(). -- error compiling committee.c: too many arguments to function