From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2 0/9] qemu-kvm: Clean up and enhance MSI irqchip support
Date: Wed, 27 Apr 2011 10:27:41 +0300 [thread overview]
Message-ID: <4DB7C56D.8040503@redhat.com> (raw)
In-Reply-To: <cover.1303823975.git.jan.kiszka@siemens.com>
On 04/26/2011 04:19 PM, Jan Kiszka wrote:
> I've still plans to consolidate MSI-X mask notifiers and KVM hooks, but
> that can wait until we go upstream.
>
> This version still makes classic MSI usable in irqchip mode, now not
> only for PCI devices (AHCI, HDA) but also for the HPET (with msi=on).
> Moreover, it contains an additional patch to refresh the MSI IRQ routes
> after vmload.
>
Patches 1-8 applied, thanks. I'm not sure about 9 (hpet kvm msi
integration) - it seems very intrusive to do this to every
msi-supporting device. At least for pci we get all pci devices done in
one shot.
We could do this transparently in hw/apic.c. When the message is sent
for the first time we look it up, fail, and update the kvm routing
entry. Next time the lookup succeeds and we just use KVM_IRQ_LINE,
until the message changes and we need to update the irq entry again.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-04-27 7:27 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 13:19 [PATCH v2 0/9] qemu-kvm: Clean up and enhance MSI irqchip support Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 1/9] qemu-kvm: Drop unneeded kvm_irq_routing_entry declaration Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 2/9] qemu-kvm: Rename kvm_msix_message to KVMMsiMessage Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 3/9] qemu-kvm: Refactor MSI core API of KVM Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 4/9] qemu-kvm: Fix and clean up msix vector use/unuse hooks Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 5/9] qemu-kvm: Move gsi bits from kvm_msix_vector_add to kvm_msi_add_message Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 6/9] qemu-kvm: Move entry comparison into kvm_msi_update_message Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 7/9] qemu-kvm: Add in-kernel irqchip support for MSI Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 8/9] qemu-kvm: Refresh MSI settings after vmload Jan Kiszka
2011-04-26 13:19 ` [PATCH v2 9/9] qemu-kvm: hpet: Add MSI support for in-kernel irqchip mode Jan Kiszka
2011-04-26 13:30 ` Michael Tokarev
2011-04-26 13:55 ` Jan Kiszka
2011-04-26 13:56 ` Avi Kivity
2011-04-26 13:58 ` Jan Kiszka
2011-04-26 14:01 ` [PATCH v3 " Jan Kiszka
2011-04-26 16:06 ` Christoph Hellwig
2011-04-26 17:06 ` Jan Kiszka
2011-04-26 17:09 ` Christoph Hellwig
2011-04-27 7:27 ` Avi Kivity [this message]
2011-04-27 9:00 ` [PATCH v2 0/9] qemu-kvm: Clean up and enhance MSI irqchip support Jan Kiszka
2011-04-27 9:04 ` Avi Kivity
2011-04-27 9:06 ` Jan Kiszka
2011-04-27 9:14 ` Avi Kivity
2011-04-27 11:21 ` Jan Kiszka
2011-04-27 12:12 ` Avi Kivity
2011-04-27 13:31 ` Jan Kiszka
2011-04-27 13:39 ` Avi Kivity
2011-04-27 13:54 ` Jan Kiszka
2011-04-27 14:01 ` Avi Kivity
2011-04-27 14:11 ` Michael S. Tsirkin
2011-04-27 14:02 ` Michael S. Tsirkin
2011-04-27 14:10 ` Jan Kiszka
2011-04-27 14:14 ` Michael S. Tsirkin
2011-04-27 14:21 ` Jan Kiszka
2011-04-27 13:49 ` Michael S. Tsirkin
2011-04-27 9:34 ` Avi Kivity
2011-04-27 11:39 ` [PATCH v2 8/9] qemu-kvm: Refresh MSI settings after vmload Jan Kiszka
2011-04-27 12:19 ` Avi Kivity
2011-04-27 14:16 ` Michael S. Tsirkin
2011-04-27 14:28 ` Jan Kiszka
2011-04-27 14:30 ` Michael S. Tsirkin
2011-04-27 14:39 ` Jan Kiszka
2011-04-27 15:09 ` Michael S. Tsirkin
2011-04-27 15:21 ` Jan Kiszka
2011-04-27 16:02 ` Michael S. Tsirkin
2011-04-27 16:20 ` Jan Kiszka
2011-04-27 16:26 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB7C56D.8040503@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox