From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 0/9] qemu-kvm: Clean up and enhance MSI irqchip support Date: Wed, 27 Apr 2011 10:27:41 +0300 Message-ID: <4DB7C56D.8040503@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, "Michael S. Tsirkin" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36446 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753461Ab1D0H1r (ORCPT ); Wed, 27 Apr 2011 03:27:47 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 04/26/2011 04:19 PM, Jan Kiszka wrote: > I've still plans to consolidate MSI-X mask notifiers and KVM hooks, but > that can wait until we go upstream. > > This version still makes classic MSI usable in irqchip mode, now not > only for PCI devices (AHCI, HDA) but also for the HPET (with msi=on). > Moreover, it contains an additional patch to refresh the MSI IRQ routes > after vmload. > Patches 1-8 applied, thanks. I'm not sure about 9 (hpet kvm msi integration) - it seems very intrusive to do this to every msi-supporting device. At least for pci we get all pci devices done in one shot. We could do this transparently in hw/apic.c. When the message is sent for the first time we look it up, fail, and update the kvm routing entry. Next time the lookup succeeds and we just use KVM_IRQ_LINE, until the message changes and we need to update the irq entry again. -- error compiling committee.c: too many arguments to function