From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: nmi is broken? Date: Wed, 27 Apr 2011 11:55:45 +0300 Message-ID: <4DB7DA11.8040503@redhat.com> References: <87sjtbe7fz.fsf@devron.myhome.or.jp> <877hak1t1s.fsf@devron.myhome.or.jp> <4DB3C6D3.9040703@redhat.com> <4DB41696.6060606@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: OGAWA Hirofumi , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11110 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754823Ab1D0Izu (ORCPT ); Wed, 27 Apr 2011 04:55:50 -0400 In-Reply-To: <4DB41696.6060606@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 04/24/2011 03:24 PM, Jan Kiszka wrote: > > > > This would cause IRQs to be delivered even if the PIT is masked, no? > > I checked the patch and our code again: NMI watchdog masking is managed > via arch.vapics_in_nmi_mode and by re-checking the per-APIC mask > situation in kvm_apic_local_deliver when delivering the NMI. > > So the patch looks correct - NMIs aren't acked like timer IRQs, the > current logic is definitely wrong. Can you elaborate? Why aren't NMIs acked (if delivered via the PIC)? Is the PIC programmed into auto-EOI mode or something? -- error compiling committee.c: too many arguments to function