From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>, kvm@vger.kernel.org
Subject: Re: nmi is broken?
Date: Wed, 27 Apr 2011 14:09:00 +0200 [thread overview]
Message-ID: <4DB8075C.2050407@siemens.com> (raw)
In-Reply-To: <4DB7DA11.8040503@redhat.com>
On 2011-04-27 10:55, Avi Kivity wrote:
> On 04/24/2011 03:24 PM, Jan Kiszka wrote:
>> >
>> > This would cause IRQs to be delivered even if the PIT is masked, no?
>>
>> I checked the patch and our code again: NMI watchdog masking is managed
>> via arch.vapics_in_nmi_mode and by re-checking the per-APIC mask
>> situation in kvm_apic_local_deliver when delivering the NMI.
>>
>> So the patch looks correct - NMIs aren't acked like timer IRQs, the
>> current logic is definitely wrong.
>
> Can you elaborate? Why aren't NMIs acked (if delivered via the PIC)?
> Is the PIC programmed into auto-EOI mode or something?
At least there are no traces of 8259 interaction in the NMI handler of
old kernels when configured to IOAPIC mode. This wouldn't work anyway as
you can't synchronize with other PIC-accessing functions from the NMI
handler.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2011-04-27 12:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 19:21 nmi is broken? OGAWA Hirofumi
2011-04-23 22:50 ` OGAWA Hirofumi
2011-04-24 6:44 ` Avi Kivity
2011-04-24 9:17 ` OGAWA Hirofumi
2011-04-24 9:46 ` Jan Kiszka
2011-04-24 11:13 ` OGAWA Hirofumi
2011-04-24 11:15 ` OGAWA Hirofumi
2011-04-24 12:24 ` Jan Kiszka
2011-04-27 8:55 ` Avi Kivity
2011-04-27 12:09 ` Jan Kiszka [this message]
2011-04-28 1:28 ` OGAWA Hirofumi
2011-04-28 9:59 ` Avi Kivity
2011-04-28 13:44 ` OGAWA Hirofumi
2011-04-28 14:23 ` OGAWA Hirofumi
2011-05-01 1:45 ` OGAWA Hirofumi
2011-05-02 8:46 ` Avi Kivity
2011-05-02 14:30 ` OGAWA Hirofumi
2011-05-03 9:36 ` Avi Kivity
2011-05-03 10:07 ` Avi Kivity
2011-05-03 13:25 ` OGAWA Hirofumi
2011-05-03 13:35 ` Avi Kivity
2011-05-03 16:57 ` OGAWA Hirofumi
2011-05-03 17:09 ` Avi Kivity
2011-05-03 17:45 ` OGAWA Hirofumi
2011-05-04 8:27 ` Avi Kivity
2011-05-04 15:40 ` OGAWA Hirofumi
2011-05-04 16:15 ` Avi Kivity
2011-04-24 14:08 ` Jan Kiszka
2011-05-03 9:43 ` Avi Kivity
2011-05-03 10:37 ` Jan Kiszka
2011-05-03 13:31 ` Avi Kivity
2011-05-03 14:29 ` Jan Kiszka
2011-05-03 14:37 ` Avi Kivity
2011-05-03 15:01 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB8075C.2050407@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=avi@redhat.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).