From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 5/7] qemu-kvm: Move gsi bits from kvm_msix_vector_add to kvm_msi_add_message Date: Wed, 27 Apr 2011 15:29:15 +0200 Message-ID: <4DB81A2B.9020603@siemens.com> References: <20110427125411.GF15788@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from thoth.sbs.de ([192.35.17.2]:26640 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758206Ab1D0N31 (ORCPT ); Wed, 27 Apr 2011 09:29:27 -0400 In-Reply-To: <20110427125411.GF15788@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-04-27 14:54, Michael S. Tsirkin wrote: > On Sat, Apr 23, 2011 at 12:23:38PM +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Testing support and allocating a GSI for an MSI message is required both >> for MSI and MSI-X. At this chance, drop the aging version warning. >> >> Signed-off-by: Jan Kiszka > > No objection, but I do note that this means running on an old > kernel will lead to a silent failure. Shouldn't be silent: The caller of msi_vector_use should check and process the error (virtio should even forward it to guest IIUC). > stderr output is not in fact much better: I think we should > check the capability in msix_init. Care coding this up? I think the motivation to check on vector activation is that devices and guests without a need for MSI should not cause a failure if MSI is unsupported by KVM. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux