From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com,
mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] rcu: export rcu_note_context_switch() function
Date: Thu, 28 Apr 2011 13:01:04 +0300 [thread overview]
Message-ID: <4DB93AE0.4050303@redhat.com> (raw)
In-Reply-To: <1303984323-3203-2-git-send-email-gleb@redhat.com>
On 04/28/2011 12:52 PM, Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov<gleb@redhat.com>
> @@ -93,11 +93,7 @@ static inline int rcu_needs_cpu(int cpu)
>
> #endif /* #else #ifdef CONFIG_TINY_RCU */
>
> -static inline void rcu_note_context_switch(int cpu)
> -{
> - rcu_sched_qs(cpu);
> - rcu_preempt_note_context_switch();
> -}
> +extern void rcu_note_context_switch(int cpu);
>
Why are you uninlining this function? Why not export the two functions
it calls instead?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-04-28 10:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 9:52 [PATCH 0/2] make kvm guest mode to be rcu quiescent state Gleb Natapov
2011-04-28 9:52 ` [PATCH 1/2] rcu: export rcu_note_context_switch() function Gleb Natapov
2011-04-28 10:01 ` Avi Kivity [this message]
2011-04-28 10:11 ` Gleb Natapov
2011-04-29 8:36 ` Paul E. McKenney
2011-04-29 8:39 ` Paul E. McKenney
2011-04-29 18:02 ` Gleb Natapov
2011-04-29 18:23 ` Gleb Natapov
2011-04-30 12:59 ` Paul E. McKenney
2011-04-30 19:43 ` Avi Kivity
2011-05-02 10:56 ` Gleb Natapov
2011-05-02 13:36 ` Paul E. McKenney
2011-05-02 14:10 ` Gleb Natapov
2011-05-03 6:25 ` Paul E. McKenney
2011-05-04 13:10 ` Gleb Natapov
2011-04-28 9:52 ` [PATCH 2/2] KVM: make guest mode entry to be rcu quiescent state Gleb Natapov
2011-05-03 13:13 ` Marcelo Tosatti
2011-05-03 13:20 ` Avi Kivity
2011-05-03 13:21 ` Gleb Natapov
2011-05-03 13:29 ` Marcelo Tosatti
2011-05-03 13:39 ` Gleb Natapov
2011-05-03 15:42 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB93AE0.4050303@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).