From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 1/2] rcu: export rcu_note_context_switch() function
Date: Thu, 28 Apr 2011 13:01:04 +0300
Message-ID: <4DB93AE0.4050303@redhat.com>
References: <1303984323-3203-1-git-send-email-gleb@redhat.com> <1303984323-3203-2-git-send-email-gleb@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com,
	mtosatti@redhat.com, kvm@vger.kernel.org
To: Gleb Natapov <gleb@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1303984323-3203-2-git-send-email-gleb@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 04/28/2011 12:52 PM, Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov<gleb@redhat.com>
> @@ -93,11 +93,7 @@ static inline int rcu_needs_cpu(int cpu)
>
>   #endif /* #else #ifdef CONFIG_TINY_RCU */
>
> -static inline void rcu_note_context_switch(int cpu)
> -{
> -	rcu_sched_qs(cpu);
> -	rcu_preempt_note_context_switch();
> -}
> +extern void rcu_note_context_switch(int cpu);
>

Why are you uninlining this function?  Why not export the two functions 
it calls instead?

-- 
error compiling committee.c: too many arguments to function