From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [Qemu-devel] [PATCH v3 1/5] hpet 'driftfix': add hooks required to detect coalesced interrupts (x86 apic only) Date: Fri, 29 Apr 2011 00:50:30 +0200 Message-ID: <4DB9EF36.1010803@web.de> References: <1304000700-3640-1-git-send-email-uobergfe@redhat.com> <1304000700-3640-2-git-send-email-uobergfe@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig3C67E407786017952BB1631E" Cc: Ulrich Obergfell , qemu-devel@nongnu.org, aliguori@us.ibm.com, kvm@vger.kernel.org, gcosta@redhat.com, avi@redhat.com To: Blue Swirl Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:48275 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932352Ab1D1Wuc (ORCPT ); Thu, 28 Apr 2011 18:50:32 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3C67E407786017952BB1631E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2011-04-28 20:51, Blue Swirl wrote: > On Thu, Apr 28, 2011 at 5:24 PM, Ulrich Obergfell = wrote: >> 'target_get_irq_delivered' and 'target_reset_irq_delivered' contain >> entry addresses of functions that are utilized by update_irq() to >> detect coalesced interrupts. apic code loads these pointers during >> initialization. >=20 > I'm not so happy with this approach, but probably then the i386 > dependencies can be removed from RTC and it can be compiled only once > for all targets. This whole series is really the minimalistic approach. The callbacks defined here must remain a temporary "shortcut". Just like proper abstraction of periodic tick compensation for reuse in other timers has to be added later on. And the limitation to edge-triggered legacy HPET INTs has to be removed. Jan --------------enig3C67E407786017952BB1631E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk257zYACgkQitSsb3rl5xSVjgCfa+PMS1E26vjJ1JEq/Altsfdn uzMAmwbUbJVbym8ZavAahrM3l2+3CsDo =ujVl -----END PGP SIGNATURE----- --------------enig3C67E407786017952BB1631E--