From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] rcu: export rcu_note_context_switch() function Date: Sat, 30 Apr 2011 22:43:16 +0300 Message-ID: <4DBC6654.5030003@redhat.com> References: <1303984323-3203-1-git-send-email-gleb@redhat.com> <1303984323-3203-2-git-send-email-gleb@redhat.com> <20110429083618.GL2191@linux.vnet.ibm.com> <20110429083904.GA12987@linux.vnet.ibm.com> <20110429180239.GA32566@redhat.com> <20110430125928.GJ2297@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , linux-kernel@vger.kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org To: paulmck@linux.vnet.ibm.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13728 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039Ab1D3TnX (ORCPT ); Sat, 30 Apr 2011 15:43:23 -0400 In-Reply-To: <20110430125928.GJ2297@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/30/2011 03:59 PM, Paul E. McKenney wrote: > > That will work, but does making rcu_note_context_switch() out of line > > actually increase kernel size? The function is called in two places > > currently, so by making it out of line we make two calling site smaller. > > Will measure it next week. > > One thing to keep in mind... Calling an out-of-line function from > KVM requires an export, each of which significantly increases TINY_RCU's > memory footprint. I would expect that most kvm configs will actually be smp (perhaps with an exception for embedded ppc). A completely random idea - how about trimming exports that aren't actually used? so if you have a minimal setup you only get the hit if you actually use kvm. (The trimming would need to be optional so external modules can continue to work for those who want them) -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.