From mboxrd@z Thu Jan  1 00:00:00 1970
From: Asias He <asias.hejun@gmail.com>
Subject: Re: [PATCH v2 1/2] KVM-test: Add qemu-ifup-atbr0
Date: Wed, 04 May 2011 11:11:10 +0800
Message-ID: <4DC0C3CE.8090109@gmail.com>
References: <1303184574.2088.4.camel@freedom> <20110504030117.16383.32625.stgit@t>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: autotest@test.kernel.org, lmr@redhat.com, kvm@vger.kernel.org
To: Amos Kong <akong@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-pv0-f174.google.com ([74.125.83.174]:36318 "EHLO
	mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754842Ab1EDDMW (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 3 May 2011 23:12:22 -0400
Received: by pvg12 with SMTP id 12so312267pvg.19
        for <kvm@vger.kernel.org>; Tue, 03 May 2011 20:12:21 -0700 (PDT)
In-Reply-To: <20110504030117.16383.32625.stgit@t>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 05/04/2011 11:01 AM, Amos Kong wrote:
> 'atbr0' is a private bridge.
> This script is used to setup tap device.
> 
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
>  client/tests/kvm/scripts/qemu-ifup-atbr0 |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
>  create mode 100755 client/tests/kvm/scripts/qemu-ifup-atbr0
> 
> diff --git a/client/tests/kvm/scripts/qemu-ifup-atbr0 b/client/tests/kvm/scripts/qemu-ifup-atbr0
> new file mode 100755
> index 0000000..82c7efa
> --- /dev/null
> +++ b/client/tests/kvm/scripts/qemu-ifup-atbr0
> @@ -0,0 +1,6 @@
> +#!/bin/sh
> +switch=atbr0
> +/sbin/ifconfig $1 0.0.0.0 up
> +/usr/sbin/brctl addif ${switch} $1
> +/usr/sbin/brctl setfd ${switch} 0
> +/usr/sbin/brctl stp ${switch} off

brctl is not in /usr/sbin but /sbin in some systems, e.g. Debian.

	hj:~# which brctl
	/sbin/brctl

Does dropping this absolute path to brctl sound better?


-- 
Best Regards,
Asias He