Re: [PATCH 3/3 V2] kvm tools: Add cmdline options for loading multiple images

[David Ahern <dsahern@gmail.com>]

On 05/04/11 09:03, Sasha Levin wrote:
> On Wed, 2011-05-04 at 08:51 -0600, David Ahern wrote:
>>
>> On 05/04/11 07:45, Sasha Levin wrote:
>>> This is a simple cmdline addition to allow loading multiple images.
>>> perf's cmdline parser doesn't support having multiple args
>>> with the same name (i.e. --image <img1> --image <img2>), so
>>> we have to choose either to extend the parser, or find a diiferent
>>> way to assign multiple images.
>>>
>>> Sample cmdline for loading 2 images:
>>> ./kvm run --image=image1.raw --readonly --image2=image2.raw --readonly2
>>
>> syntax is getting a bit unwieldy. Why not use a scheme similar to qemu
>> and concatenate related arguments into one and handle multiple usages?
>> e.g., --image=image1.raw,ro --image=image2.raw,ro
> 
> That'll probably how it'll end up being. Currently the cmdline parser
> doesn't support it and I didn't want to mix parser changes with
> virtio-blk patch.

It's using the option parser from perf, so you need to change:

OPT_STRING('i', "image", &image_filename, "image", "Disk image"),

to OPT_CALLBACK and create a parser function specific to this input
argument. For example, checkout tools/perf/builtin-script.c,
parse_output_fields.

The parser is specific to the image argument and hence should be a part
of this change set.

David


> 
> This patch should just allow testing of the multiple virtio-blk feature.
>