* VMSTATE_U64 vs. VMSTATE_UINT64
@ 2011-05-04 18:04 Jan Kiszka
2011-05-04 18:16 ` Glauber Costa
2011-05-09 13:04 ` Juan Quintela
0 siblings, 2 replies; 6+ messages in thread
From: Jan Kiszka @ 2011-05-04 18:04 UTC (permalink / raw)
To: Glauber Costa, Juan Quintela; +Cc: kvm
Hi guys,
can anyone comment on commit e4d6d49061 ("introduce VMSTATE_U64") in
qemu-kvm again? I strongly suspect this thing was only introduced to be
able to grab from a __u64 (for kvmclock) without generating a compiler
warning that you may got when using uint64_t, right?
Thanks,
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: VMSTATE_U64 vs. VMSTATE_UINT64
2011-05-04 18:04 VMSTATE_U64 vs. VMSTATE_UINT64 Jan Kiszka
@ 2011-05-04 18:16 ` Glauber Costa
2011-05-04 18:24 ` Jan Kiszka
2011-05-09 13:04 ` Juan Quintela
1 sibling, 1 reply; 6+ messages in thread
From: Glauber Costa @ 2011-05-04 18:16 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Juan Quintela, kvm
On Wed, 2011-05-04 at 20:04 +0200, Jan Kiszka wrote:
> Hi guys,
>
> can anyone comment on commit e4d6d49061 ("introduce VMSTATE_U64") in
> qemu-kvm again? I strongly suspect this thing was only introduced to be
> able to grab from a __u64 (for kvmclock) without generating a compiler
> warning that you may got when using uint64_t, right?
>
> Thanks,
> Jan
>
I don't remember if it was kvmclock. IIRC, it was my irqchip
implementation at the time. But I do remember the reason: it was indeed
to be able to grab kernel data structures directly without a compile
warning.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: VMSTATE_U64 vs. VMSTATE_UINT64
2011-05-04 18:16 ` Glauber Costa
@ 2011-05-04 18:24 ` Jan Kiszka
2011-05-04 18:32 ` Trouble activating windows xp when booted with KVM Salame, Majid (Majid)
2011-05-04 19:44 ` VMSTATE_U64 vs. VMSTATE_UINT64 Glauber Costa
0 siblings, 2 replies; 6+ messages in thread
From: Jan Kiszka @ 2011-05-04 18:24 UTC (permalink / raw)
To: Glauber Costa; +Cc: Juan Quintela, kvm
On 2011-05-04 20:16, Glauber Costa wrote:
> On Wed, 2011-05-04 at 20:04 +0200, Jan Kiszka wrote:
>> Hi guys,
>>
>> can anyone comment on commit e4d6d49061 ("introduce VMSTATE_U64") in
>> qemu-kvm again? I strongly suspect this thing was only introduced to be
>> able to grab from a __u64 (for kvmclock) without generating a compiler
>> warning that you may got when using uint64_t, right?
>>
>> Thanks,
>> Jan
>>
> I don't remember if it was kvmclock. IIRC, it was my irqchip
> implementation at the time. But I do remember the reason: it was indeed
> to be able to grab kernel data structures directly without a compile
> warning.
>
Perfect. Then I will also include a revert/drop patch in my series that
switches the only user, kvmclock, to the upstream version.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 6+ messages in thread* Trouble activating windows xp when booted with KVM
2011-05-04 18:24 ` Jan Kiszka
@ 2011-05-04 18:32 ` Salame, Majid (Majid)
2011-05-04 19:44 ` VMSTATE_U64 vs. VMSTATE_UINT64 Glauber Costa
1 sibling, 0 replies; 6+ messages in thread
From: Salame, Majid (Majid) @ 2011-05-04 18:32 UTC (permalink / raw)
To: kvm
Hi all,
I used qemu-kvm to create a windows xp image.
The image boots fine on rhel5 64 bit and up and running with networking. However I seem to have issue activating from a window instance over KVM and fine with real hardware.
I am using kvm-86 version.
Host is rhel5 linux 64 bit.
Guest is Windows xp pro sp2
Has anyone encountered this issue ?
Cheers,
Majid
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: VMSTATE_U64 vs. VMSTATE_UINT64
2011-05-04 18:24 ` Jan Kiszka
2011-05-04 18:32 ` Trouble activating windows xp when booted with KVM Salame, Majid (Majid)
@ 2011-05-04 19:44 ` Glauber Costa
1 sibling, 0 replies; 6+ messages in thread
From: Glauber Costa @ 2011-05-04 19:44 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Juan Quintela, kvm
On Wed, 2011-05-04 at 20:24 +0200, Jan Kiszka wrote:
> On 2011-05-04 20:16, Glauber Costa wrote:
> > On Wed, 2011-05-04 at 20:04 +0200, Jan Kiszka wrote:
> >> Hi guys,
> >>
> >> can anyone comment on commit e4d6d49061 ("introduce VMSTATE_U64") in
> >> qemu-kvm again? I strongly suspect this thing was only introduced to be
> >> able to grab from a __u64 (for kvmclock) without generating a compiler
> >> warning that you may got when using uint64_t, right?
> >>
> >> Thanks,
> >> Jan
> >>
> > I don't remember if it was kvmclock. IIRC, it was my irqchip
> > implementation at the time. But I do remember the reason: it was indeed
> > to be able to grab kernel data structures directly without a compile
> > warning.
> >
>
> Perfect. Then I will also include a revert/drop patch in my series that
> switches the only user, kvmclock, to the upstream version.
>
> Jan
>
I am fine with that.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: VMSTATE_U64 vs. VMSTATE_UINT64
2011-05-04 18:04 VMSTATE_U64 vs. VMSTATE_UINT64 Jan Kiszka
2011-05-04 18:16 ` Glauber Costa
@ 2011-05-09 13:04 ` Juan Quintela
1 sibling, 0 replies; 6+ messages in thread
From: Juan Quintela @ 2011-05-09 13:04 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Glauber Costa, kvm
Jan Kiszka <jan.kiszka@siemens.com> wrote:
> Hi guys,
>
> can anyone comment on commit e4d6d49061 ("introduce VMSTATE_U64") in
> qemu-kvm again? I strongly suspect this thing was only introduced to be
> able to grab from a __u64 (for kvmclock) without generating a compiler
> warning that you may got when using uint64_t, right?
Yes, it was that on 64 bit u64 was unsigned long long and uint64_t was
only unsigned long or something like that. I have forgot if it was
kvmclock or irqchip also. I think that Marcelo also requested it at
some point, but dont' remember details :-(
Later, Juan.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-05-09 13:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-04 18:04 VMSTATE_U64 vs. VMSTATE_UINT64 Jan Kiszka
2011-05-04 18:16 ` Glauber Costa
2011-05-04 18:24 ` Jan Kiszka
2011-05-04 18:32 ` Trouble activating windows xp when booted with KVM Salame, Majid (Majid)
2011-05-04 19:44 ` VMSTATE_U64 vs. VMSTATE_UINT64 Glauber Costa
2011-05-09 13:04 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox