From: Jan Kiszka <jan.kiszka@siemens.com>
To: Glauber Costa <glommer@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: VMSTATE_U64 vs. VMSTATE_UINT64
Date: Wed, 04 May 2011 20:24:11 +0200 [thread overview]
Message-ID: <4DC199CB.30001@siemens.com> (raw)
In-Reply-To: <1304532978.4737.32.camel@mothafucka.localdomain>
On 2011-05-04 20:16, Glauber Costa wrote:
> On Wed, 2011-05-04 at 20:04 +0200, Jan Kiszka wrote:
>> Hi guys,
>>
>> can anyone comment on commit e4d6d49061 ("introduce VMSTATE_U64") in
>> qemu-kvm again? I strongly suspect this thing was only introduced to be
>> able to grab from a __u64 (for kvmclock) without generating a compiler
>> warning that you may got when using uint64_t, right?
>>
>> Thanks,
>> Jan
>>
> I don't remember if it was kvmclock. IIRC, it was my irqchip
> implementation at the time. But I do remember the reason: it was indeed
> to be able to grab kernel data structures directly without a compile
> warning.
>
Perfect. Then I will also include a revert/drop patch in my series that
switches the only user, kvmclock, to the upstream version.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2011-05-04 18:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 18:04 VMSTATE_U64 vs. VMSTATE_UINT64 Jan Kiszka
2011-05-04 18:16 ` Glauber Costa
2011-05-04 18:24 ` Jan Kiszka [this message]
2011-05-04 18:32 ` Trouble activating windows xp when booted with KVM Salame, Majid (Majid)
2011-05-04 19:44 ` VMSTATE_U64 vs. VMSTATE_UINT64 Glauber Costa
2011-05-09 13:04 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC199CB.30001@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox