From mboxrd@z Thu Jan  1 00:00:00 1970
From: Asias He <asias.hejun@gmail.com>
Subject: Re: [PATCH 2/2 V2] kvm tools: Fix virt_queue__set_used_elem
Date: Thu, 05 May 2011 07:47:07 +0800
Message-ID: <4DC1E57B.3060809@gmail.com>
References: <1304454487-2539-1-git-send-email-levinsasha928@gmail.com>	 <1304454487-2539-2-git-send-email-levinsasha928@gmail.com>	 <20110503204716.GA27887@elte.hu> <1304484063.13143.9.camel@lappy>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Ingo Molnar <mingo@elte.hu>, penberg@kernel.org,
	gorcunov@gmail.com, prasadjoshi124@gmail.com, kvm@vger.kernel.org
To: Sasha Levin <levinsasha928@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-px0-f173.google.com ([209.85.212.173]:62692 "EHLO
	mail-px0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755833Ab1EDXsQ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 4 May 2011 19:48:16 -0400
Received: by pxi16 with SMTP id 16so1274477pxi.4
        for <kvm@vger.kernel.org>; Wed, 04 May 2011 16:48:16 -0700 (PDT)
In-Reply-To: <1304484063.13143.9.camel@lappy>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 05/04/2011 12:41 PM, Sasha Levin wrote:
> On Tue, 2011-05-03 at 22:47 +0200, Ingo Molnar wrote:
>> * Sasha Levin <levinsasha928@gmail.com> wrote:
>>
>>> Increase idx only after updating the used element.
>>> Not doing so may mark a buffer as used without having
>>> it's head and length updated.
>>>
>>> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
>>> ---
>>>  tools/kvm/virtio.c |   19 ++++++++++++++++++-
>>>  1 files changed, 18 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/tools/kvm/virtio.c b/tools/kvm/virtio.c
>>> index 6249521..266a1b6 100644
>>> --- a/tools/kvm/virtio.c
>>> +++ b/tools/kvm/virtio.c
>>> @@ -1,15 +1,32 @@
>>>  #include <linux/virtio_ring.h>
>>>  #include <stdint.h>
>>>  #include <sys/uio.h>
>>> +#include <asm/system.h>
>>
>> If this system.h is included from the current kernel (and not from the 
>> system's) then:
>>
>> Acked-by: Ingo Molnar <mingo@elte.hu>
>>
> 
> The system.h that'll get picked up is
> '../../arch/$(ARCH)/include/asm/system.h' within the current kernel tree
> and not the system one.
>> Thanks,
>>
>> 	Ingo
> 

Hi,

With commit d7f0c07afeefa2d20739437306e4b8bb2853cf83 in master
(kvm tools: Fix virt_queue__set_used_elem)

I see this:

asias@hj:~/qemu-stuff/pekka.git/tools/kvm$ make
  GEN      include/common-cmds.h
../../include/asm-generic/bitops/fls64.h:33:2: error: #error
BITS_PER_LONG not 32 or 64
../../include/linux/bitops.h:133:2: error: #error BITS_PER_LONG not 32 or 64
../../include/asm-generic/bitops/fls64.h:33:2: error: #error
BITS_PER_LONG not 32 or 64
../../include/linux/bitops.h:133:2: error: #error BITS_PER_LONG not 32 or 64
make: *** No rule to make target `virtio.d', needed by `kvm'.  Stop.


With 'make V=1', I found this one triggered the error:

cc -M -MT virtio.o  -DCONFIG_X86_32 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
-Iinclude -I../../include -I../../arch/x86/include/ -Os -g -Werror -Wall
-Wcast-align -Wformat=2 -Winit-self -Wmissing-declarations
-Wmissing-prototypes -Wnested-externs -Wno-system-headers
-Wold-style-definition -Wredundant-decls -Wsign-compare
-Wstrict-prototypes -Wundef -Wvolatile-register-var -Wwrite-strings
virtio.c -o virtio.d


-- 
Best Regards,
Asias He