From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 04/19] qemu-kvm: x86: Drop MSR reset Date: Thu, 05 May 2011 11:08:19 +0300 Message-ID: <4DC25AF3.6050704@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17043 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752213Ab1EEIIX (ORCPT ); Thu, 5 May 2011 04:08:23 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 05/04/2011 10:43 PM, Jan Kiszka wrote: > From: Jan Kiszka > > Paravirtual MSRs are properly cleared on reset now, and blindly clearing > the rest is questionable anyway (better address those one by one, > re-initializing their backing CPU state fields). > This can introduce a regression when new paravirtual MSRs are added. So we either need to port this, or query the reset state from the kernel immediately after creating the vcpu and saving it. -- error compiling committee.c: too many arguments to function