From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 00/19] qemu-kvm: Cleanup and switch to upstream - Part I Date: Thu, 05 May 2011 11:22:16 +0300 Message-ID: <4DC25E38.1080609@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:57075 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751338Ab1EEIWU (ORCPT ); Thu, 5 May 2011 04:22:20 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 05/04/2011 10:43 PM, Jan Kiszka wrote: > All required bits for this cleanup of qemu-kvm are now upstream and > merged back - it's time to start the show. There are now 65 patches in > my queue, and I'm planning for at least 4 rounds. > > This first part primarily aims at using upstream kvm_arch_init. Further > highlights are: > - switch to upstream CPU register get/put > - switch to upstream kvmclock > - sustainable breakage of IA64 > > Please review/merge. > I didn't do a line-by-line review, just a general look around, and it all looks good except for the MSR behavioural change. How did you test it? I suggest testing at least vmport in addition to an autotest run (if you don't have a setup ready, we can do it, but it would be really helpful to test pre-merge). I guess we can expect a few regressions but if we're too careful this mess will continue forever. -- error compiling committee.c: too many arguments to function