From: Asias He <asias.hejun@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Sasha Levin <levinsasha928@gmail.com>,
gorcunov@gmail.com, prasadjoshi124@gmail.com,
kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: Fix 32-bit build of the asm/system.h include
Date: Thu, 05 May 2011 23:33:46 +0800 [thread overview]
Message-ID: <4DC2C35A.9060403@gmail.com> (raw)
In-Reply-To: <1304606701.10621.1.camel@jaguar>
On 05/05/2011 10:45 PM, Pekka Enberg wrote:
> On Thu, 2011-05-05 at 10:22 +0200, Ingo Molnar wrote:
>> * Ingo Molnar <mingo@elte.hu> wrote:
>>
>>> * Ingo Molnar <mingo@elte.hu> wrote:
>>>
>>>> I'm not entirely happy about how it has added dependent includes to virtio.c
>>>> but that's a property of this messy header file. Might be worth adding a
>>>> comment about that.
>>>
>>> This block:
>>>
>>>> +#include <linux/stringify.h>
>>>> +#include <linux/bitops.h>
>>>> +#include <asm/alternative.h>
>>>> #include <asm/system.h>
>>>
>>> Could be put into a new tools/kvm/include/kvm/barrier.h file, with a comment -
>>> that way the virtio.c inclusion looks very clean.
>>>
>>> Note: i'd not put it into linux/barrier.h, to not clash with any possible
>>> future linux/barrier.h file, and to also make it clear that this is a kvm
>>> specific wrapper.
>>
>> Like the more complete patch below. Build-tested on 32-bit and 64-bit systems,
>> boot tested on a 64-bit box.
>
> Applied, thanks Ingo! Asias, please let me know if master doesn't build
> for you still.
Works for me now.
--
Best Regards,
Asias He
next prev parent reply other threads:[~2011-05-05 15:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 20:28 [PATCH 1/2 V2] kvm tools: Drop ALIGN from bios.h Sasha Levin
2011-05-03 20:28 ` [PATCH 2/2 V2] kvm tools: Fix virt_queue__set_used_elem Sasha Levin
2011-05-03 20:47 ` Ingo Molnar
2011-05-04 4:41 ` Sasha Levin
2011-05-04 6:33 ` Ingo Molnar
2011-05-04 23:47 ` Asias He
2011-05-05 4:38 ` Sasha Levin
2011-05-05 7:02 ` Ingo Molnar
2011-05-05 7:13 ` Pekka Enberg
2011-05-05 7:18 ` Sasha Levin
2011-05-05 7:32 ` Pekka Enberg
2011-05-05 7:47 ` Ingo Molnar
2011-05-05 7:52 ` Pekka Enberg
2011-05-05 8:01 ` Sasha Levin
2011-05-05 8:07 ` Ingo Molnar
2011-05-05 8:12 ` Ingo Molnar
2011-05-05 8:22 ` [PATCH] kvm: Fix 32-bit build of the asm/system.h include Ingo Molnar
2011-05-05 14:45 ` Pekka Enberg
2011-05-05 15:33 ` Asias He [this message]
2011-05-03 20:35 ` [PATCH 1/2 V2] kvm tools: Drop ALIGN from bios.h Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC2C35A.9060403@gmail.com \
--to=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox