From mboxrd@z Thu Jan 1 00:00:00 1970 From: Asias He Subject: Re: [PATCH] kvm: Fix 32-bit build of the asm/system.h include Date: Thu, 05 May 2011 23:33:46 +0800 Message-ID: <4DC2C35A.9060403@gmail.com> References: <1304454487-2539-2-git-send-email-levinsasha928@gmail.com> <20110503204716.GA27887@elte.hu> <1304484063.13143.9.camel@lappy> <4DC1E57B.3060809@gmail.com> <20110505070211.GA13043@elte.hu> <20110505074716.GC14391@elte.hu> <20110505080729.GD14391@elte.hu> <20110505081253.GA20499@elte.hu> <20110505082215.GA20719@elte.hu> <1304606701.10621.1.camel@jaguar> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Ingo Molnar , Sasha Levin , gorcunov@gmail.com, prasadjoshi124@gmail.com, kvm@vger.kernel.org To: Pekka Enberg Return-path: Received: from mail-pv0-f174.google.com ([74.125.83.174]:61547 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754335Ab1EEPe6 (ORCPT ); Thu, 5 May 2011 11:34:58 -0400 Received: by pvg12 with SMTP id 12so1013612pvg.19 for ; Thu, 05 May 2011 08:34:58 -0700 (PDT) In-Reply-To: <1304606701.10621.1.camel@jaguar> Sender: kvm-owner@vger.kernel.org List-ID: On 05/05/2011 10:45 PM, Pekka Enberg wrote: > On Thu, 2011-05-05 at 10:22 +0200, Ingo Molnar wrote: >> * Ingo Molnar wrote: >> >>> * Ingo Molnar wrote: >>> >>>> I'm not entirely happy about how it has added dependent includes to virtio.c >>>> but that's a property of this messy header file. Might be worth adding a >>>> comment about that. >>> >>> This block: >>> >>>> +#include >>>> +#include >>>> +#include >>>> #include >>> >>> Could be put into a new tools/kvm/include/kvm/barrier.h file, with a comment - >>> that way the virtio.c inclusion looks very clean. >>> >>> Note: i'd not put it into linux/barrier.h, to not clash with any possible >>> future linux/barrier.h file, and to also make it clear that this is a kvm >>> specific wrapper. >> >> Like the more complete patch below. Build-tested on 32-bit and 64-bit systems, >> boot tested on a 64-bit box. > > Applied, thanks Ingo! Asias, please let me know if master doesn't build > for you still. Works for me now. -- Best Regards, Asias He