From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: penberg@kernel.org, mingo@elte.hu, asias.hejun@gmail.com,
prasadjoshi124@gmail.com, kvm@vger.kernel.org,
levinsasha928@gmail.com
Subject: Re: [patch 1/2] kvm tools: Gather Virtio-PCI constants into one place
Date: Thu, 05 May 2011 23:11:34 +0400 [thread overview]
Message-ID: <4DC2F666.60903@gmail.com> (raw)
In-Reply-To: <20110505190733.367888565@gmail.com>
On 05/05/2011 11:06 PM, Cyrill Gorcunov wrote:
> It's better than have them sprinkled in.c files. Note
> that pin for ring device is changed so it no longer shared
> with block device (it is done in a sake of simplicity).
>
> Also comment style if a bit tuned up in virtio-pci.h
^^
Have no idea what 'if' is doing here O_o
> just to be consistent.
>
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
--
Thanks,
Cyrill
next prev parent reply other threads:[~2011-05-05 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 19:06 [patch 0/2] kvm-tools -- cleanup Cyrill Gorcunov
2011-05-05 19:06 ` [patch 1/2] kvm tools: Gather Virtio-PCI constants into one place Cyrill Gorcunov
2011-05-05 19:11 ` Cyrill Gorcunov [this message]
2011-05-05 20:09 ` Cyrill Gorcunov
2011-05-05 19:06 ` [patch 2/2] kvm tools - Cleanup IRQs definitions for virtio pci devices Cyrill Gorcunov
2011-05-05 20:14 ` Pekka Enberg
2011-05-05 20:15 ` Cyrill Gorcunov
2011-05-05 20:16 ` Pekka Enberg
2011-05-05 20:19 ` Cyrill Gorcunov
2011-05-05 20:24 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC2F666.60903@gmail.com \
--to=gorcunov@gmail.com \
--cc=asias.hejun@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox