From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrill Gorcunov Subject: Re: [patch 1/2] kvm tools: Gather Virtio-PCI constants into one place Date: Thu, 05 May 2011 23:11:34 +0400 Message-ID: <4DC2F666.60903@gmail.com> References: <20110505190639.741709609@gmail.com> <20110505190733.367888565@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: penberg@kernel.org, mingo@elte.hu, asias.hejun@gmail.com, prasadjoshi124@gmail.com, kvm@vger.kernel.org, levinsasha928@gmail.com To: Cyrill Gorcunov Return-path: Received: from mail-ew0-f46.google.com ([209.85.215.46]:61447 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344Ab1EETLi (ORCPT ); Thu, 5 May 2011 15:11:38 -0400 Received: by ewy4 with SMTP id 4so766374ewy.19 for ; Thu, 05 May 2011 12:11:37 -0700 (PDT) In-Reply-To: <20110505190733.367888565@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/05/2011 11:06 PM, Cyrill Gorcunov wrote: > It's better than have them sprinkled in.c files. Note > that pin for ring device is changed so it no longer shared > with block device (it is done in a sake of simplicity). > > Also comment style if a bit tuned up in virtio-pci.h ^^ Have no idea what 'if' is doing here O_o > just to be consistent. > > Reported-by: Ingo Molnar > Signed-off-by: Cyrill Gorcunov > --- -- Thanks, Cyrill