From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: Pekka Enberg <penberg@kernel.org>, Ingo Molnar <mingo@elte.hu>,
Asias He <asias.hejun@gmail.com>,
Prasad Joshi <prasadjoshi124@gmail.com>,
kvm-vger <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm tools: PCI -- Make PCI device numbers being unique
Date: Sun, 08 May 2011 22:54:06 +0400 [thread overview]
Message-ID: <4DC6E6CE.70508@gmail.com> (raw)
In-Reply-To: <1304880489.12850.9.camel@lappy>
On 05/08/2011 10:48 PM, Sasha Levin wrote:
> On Sun, 2011-05-08 at 22:29 +0400, Cyrill Gorcunov wrote:
>> Index: linux-2.6.git/tools/kvm/virtio/rng.c
>> =====================================================================
>> --- linux-2.6.git.orig/tools/kvm/virtio/rng.c
>> +++ linux-2.6.git/tools/kvm/virtio/rng.c
>> @@ -178,5 +178,5 @@ void virtio_rng__init(struct kvm *kvm)
>> virtio_rng_pci_device.irq_line = line;
>> pci__register(&virtio_rng_pci_device, dev);
>>
>> - ioport__register(IOPORT_VIRTIO_RNG, &virtio_rng_io_ops, IOPORT_VIRTIO_RNG_SIZE);
>> + ioport__register(PCI_DEVICE_VIRTIO_RNG, &virtio_rng_io_ops, IOPORT_VIRTIO_RNG_SIZE);
>> }
>
> I think you wanted to change irq__register_device, not ioport__register
> in virtio-rng.
>
Good catch Sasha, thanks!
--
Cyrill
next prev parent reply other threads:[~2011-05-08 18:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 18:29 [PATCH] kvm tools: PCI -- Make PCI device numbers being unique Cyrill Gorcunov
2011-05-08 18:48 ` Sasha Levin
2011-05-08 18:54 ` Cyrill Gorcunov [this message]
2011-05-08 19:03 ` Cyrill Gorcunov
2011-05-09 19:53 ` Pekka Enberg
2011-05-09 20:10 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC6E6CE.70508@gmail.com \
--to=gorcunov@gmail.com \
--cc=asias.hejun@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox