From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH] kvm tools: PCI -- Make PCI device numbers being unique
Date: Sun, 08 May 2011 22:54:06 +0400
Message-ID: <4DC6E6CE.70508@gmail.com>
References: <4DC6E111.805@gmail.com> <1304880489.12850.9.camel@lappy>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Pekka Enberg <penberg@kernel.org>, Ingo Molnar <mingo@elte.hu>,
	Asias He <asias.hejun@gmail.com>,
	Prasad Joshi <prasadjoshi124@gmail.com>,
	kvm-vger <kvm@vger.kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-ew0-f46.google.com ([209.85.215.46]:37200 "EHLO
	mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932230Ab1EHSyN (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 8 May 2011 14:54:13 -0400
Received: by ewy4 with SMTP id 4so1368552ewy.19
        for <kvm@vger.kernel.org>; Sun, 08 May 2011 11:54:12 -0700 (PDT)
In-Reply-To: <1304880489.12850.9.camel@lappy>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 05/08/2011 10:48 PM, Sasha Levin wrote:
> On Sun, 2011-05-08 at 22:29 +0400, Cyrill Gorcunov wrote:
>> Index: linux-2.6.git/tools/kvm/virtio/rng.c
>> =====================================================================
>> --- linux-2.6.git.orig/tools/kvm/virtio/rng.c
>> +++ linux-2.6.git/tools/kvm/virtio/rng.c
>> @@ -178,5 +178,5 @@ void virtio_rng__init(struct kvm *kvm)
>>  	virtio_rng_pci_device.irq_line	= line;
>>  	pci__register(&virtio_rng_pci_device, dev);
>>
>> -	ioport__register(IOPORT_VIRTIO_RNG, &virtio_rng_io_ops, IOPORT_VIRTIO_RNG_SIZE);
>> +	ioport__register(PCI_DEVICE_VIRTIO_RNG, &virtio_rng_io_ops, IOPORT_VIRTIO_RNG_SIZE);
>>  }
> 
> I think you wanted to change irq__register_device, not ioport__register
> in virtio-rng.
> 

Good catch Sasha, thanks!

-- 
            Cyrill