From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 15/30] nVMX: Move host-state field setup to a function Date: Mon, 09 May 2011 12:56:28 +0300 Message-ID: <4DC7BA4C.5040106@redhat.com> References: <1304842511-nyh@il.ibm.com> <201105080822.p488MsMX018199@rice.haifa.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, gleb@redhat.com To: "Nadav Har'El" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:4503 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751650Ab1EIJ4d (ORCPT ); Mon, 9 May 2011 05:56:33 -0400 In-Reply-To: <201105080822.p488MsMX018199@rice.haifa.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/08/2011 11:22 AM, Nadav Har'El wrote: > Move the setting of constant host-state fields (fields that do not change > throughout the life of the guest) from vmx_vcpu_setup to a new common function > vmx_set_constant_host_state(). This function will also be used to set the > host state when running L2 guests. > */ > static int vmx_vcpu_setup(struct vcpu_vmx *vmx) > { > - u32 host_sysenter_cs, msr_low, msr_high; > - u32 junk; > + u32 msr_low, msr_high; Unused? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.