From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrill Gorcunov Subject: [PATCH] kvm tools: Add debug() helper Date: Wed, 11 May 2011 20:10:51 +0400 Message-ID: <4DCAB50B.9030605@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Ingo Molnar , Asias He , Sasha Levin , Prasad Joshi , kvm-vger To: Pekka Enberg Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:46051 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757177Ab1EKQK5 (ORCPT ); Wed, 11 May 2011 12:10:57 -0400 Received: by eyx24 with SMTP id 24so186079eyx.19 for ; Wed, 11 May 2011 09:10:56 -0700 (PDT) Sender: kvm-owner@vger.kernel.org List-ID: Useful for debugging. It adds "--debug" option as well so debug prints are seen only if user asked for them. Signed-off-by: Cyrill Gorcunov --- No real users in code yet, the patches with debug() are in stage, posted out to not loose it. Thanks. tools/kvm/Documentation/kvm-run.txt | 3 +++ tools/kvm/include/kvm/util.h | 10 ++++++++++ tools/kvm/kvm-run.c | 4 ++++ 3 files changed, 17 insertions(+) Index: linux-2.6.git/tools/kvm/Documentation/kvm-run.txt ===================================================================== --- linux-2.6.git.orig/tools/kvm/Documentation/kvm-run.txt +++ linux-2.6.git/tools/kvm/Documentation/kvm-run.txt @@ -55,6 +55,9 @@ OPTIONS --cpus:: The number of virtual CPUs to run. +--debug:: + Enable debug messages. + SEE ALSO -------- linkkvm: Index: linux-2.6.git/tools/kvm/include/kvm/util.h ===================================================================== --- linux-2.6.git.orig/tools/kvm/include/kvm/util.h +++ linux-2.6.git/tools/kvm/include/kvm/util.h @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -29,6 +30,8 @@ #endif #endif +extern bool do_debug_print; + extern void die(const char *err, ...) NORETURN __attribute__((format (printf, 1, 2))); extern void die_perror(const char *s) NORETURN; extern int error(const char *err, ...) __attribute__((format (printf, 1, 2))); @@ -36,6 +39,13 @@ extern void warning(const char *err, ... extern void info(const char *err, ...) __attribute__((format (printf, 1, 2))); extern void set_die_routine(void (*routine)(const char *err, va_list params) NORETURN); +#define debug(fmt, ...) \ + do { \ + if (do_debug_print) \ + info("(%s) %s:%d: " fmt, __FILE__, \ + __func__, __LINE__, ##__VA_ARGS__); \ + } while (0) + #define BUILD_BUG_ON(condition) ((void)sizeof(char[1 - 2*!!(condition)])) #define DIE_IF(cnd) \ Index: linux-2.6.git/tools/kvm/kvm-run.c ===================================================================== --- linux-2.6.git.orig/tools/kvm/kvm-run.c +++ linux-2.6.git/tools/kvm/kvm-run.c @@ -66,6 +66,8 @@ static bool virtio_rng; extern bool ioport_debug; extern int active_console; +bool do_debug_print = false; + static int nrcpus = 1; static const char * const run_usage[] = { @@ -126,6 +128,8 @@ static const struct option options[] = { "Enable single stepping"), OPT_BOOLEAN('g', "ioport-debug", &ioport_debug, "Enable ioport debugging"), + OPT_BOOLEAN('\0', "debug", &do_debug_print, + "Enable debug messages"), OPT_END() };