From mboxrd@z Thu Jan  1 00:00:00 1970
From: Asias He <asias.hejun@gmail.com>
Subject: Re: [PATCH 1/2] kvm tools: Use '-c' for '--cpus', not '--console'
Date: Thu, 12 May 2011 09:09:10 +0800
Message-ID: <4DCB3336.5060401@gmail.com>
References: <1305136906-14496-1-git-send-email-penberg@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Ingo Molnar <mingo@elte.hu>,
	Prasad Joshi <prasadjoshi124@gmail.com>,
	Sasha Levin <levinsasha928@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-pw0-f46.google.com ([209.85.160.46]:64824 "EHLO
	mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750937Ab1ELBK2 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 11 May 2011 21:10:28 -0400
Received: by pwi15 with SMTP id 15so497484pwi.19
        for <kvm@vger.kernel.org>; Wed, 11 May 2011 18:10:27 -0700 (PDT)
In-Reply-To: <1305136906-14496-1-git-send-email-penberg@kernel.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 05/12/2011 02:01 AM, Pekka Enberg wrote:
> This patch changes the '-c' command line option to specify the number of CPUs
> because it's used more often than console switching.

I'd like to tune the command line option further.

1)
Change
    -i, --image <image>   Disk image
to
    -d, --disk  <disk>	  Disk image
2)
Change
    -r, --initrd <initrd>
                          Initial RAM disk image
to
    -i, --initrd <initrd>
                          Initial RAM disk image
3)
Change
    -d, --kvm-dev <kvm-dev>
                          KVM device file
    -s, --single-step     Enable single stepping
    -g, --ioport-debug    Enable ioport debugging
to
        --kvm-dev <kvm-dev>
                          KVM device file
        --single-step     Enable single stepping
        --ioport-debug    Enable ioport debugging
.

So we can have
	-c --cpus
	-m --mem
	-d --disk
	-k --kernel
	-i --initrd
which is more consistent and easy to remember.


-- 
Best Regards,
Asias He